Re: [PATCH v3 01/38] backlight/bd6107: Compare against struct fb_info.device

From
Thomas Zimmermann <tzimmermann@suse.de>
Date
2023-06-14 14:13:18
Also in
dri-devel, linux-omap, linux-sh, linux-staging, lkml, stable
Reply to
Lee Jones, 2023-06-14
Hi

Am 14.06.23 um 15:51 schrieb Lee Jones:
On Tue, 13 Jun 2023, Thomas Zimmermann wrote:
quoted
Struct bd6107_platform_data refers to a platform device within
the Linux device hierarchy. The test in bd6107_backlight_check_fb()
compares it against the fbdev device in struct fb_info.dev, which
is different. Fix the test by comparing to struct fb_info.device.

Fixes a bug in the backlight driver and prepares fbdev for making
struct fb_info.dev optional.

v2:
	* move renames into separate patch (Javier, Sam, Michael)

Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver")
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Lee Jones <lee@kernel.org>
Cc: Daniel Thompson <redacted>
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: <redacted>
Cc: <redacted> # v3.12+
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Sam Ravnborg <redacted>
Reviewed-by: Daniel Thompson <redacted>
---
  drivers/video/backlight/bd6107.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Can the Backlight patches be applied without the others and visa versa?
Unfortunately not. The rest of the series requires the backlight patches.

Best regards
Thomas
-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Attachments

Thread (46 messages) 46 messages, 3 authors, last reply 2023-06-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help