Re: [PATCH 1/2] backlight: gpio_backlight: add new property default-brightness-level
From: Daniel Thompson <hidden>
Date: 2023-05-26 10:27:17
Also in:
dri-devel, linux-devicetree, linux-leds, lkml
On Fri, May 19, 2023 at 11:05:19PM +0300, Alexandru Ardelean wrote:
From: Yannick Fertre <yannick.fertre@foss.st.com> Add new property to set a brightness by default at probe. Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com> Signed-off-by: Yannick Fertre <yannick.fertre@foss.st.com> Signed-off-by: Alexandru Ardelean <redacted>
Patch order should be reversed for v2. Nevertheless: Reviewed-by: Daniel Thompson <redacted> Daniel.
quoted hunk ↗ jump to hunk
struct backlight_device *bl; struct gpio_backlight *gbl; int ret, init_brightness, def_value; + u32 value; gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL); if (gbl == NULL)@@ -93,7 +94,11 @@ static int gpio_backlight_probe(struct platform_device *pdev) else bl->props.power = FB_BLANK_UNBLANK; - bl->props.brightness = 1; + ret = device_property_read_u32(dev, "default-brightness-level", &value); + if (!ret && value <= props.max_brightness) + bl->props.brightness = value; + else + bl->props.brightness = 1; init_brightness = backlight_get_brightness(bl); ret = gpiod_direction_output(gbl->gpiod, init_brightness); --2.40.1