Thread (21 messages) 21 messages, 8 authors, 2023-07-10

Re: [PATCH 2/2] drm/ofdrm: Update expected device name

From: Linux regression tracking (Thorsten Leemhuis) <hidden>
Date: 2023-05-22 09:38:20
Also in: dri-devel, linux-devicetree, lkml, regressions, stable

Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
for once, to make this easily accessible to everyone.

Was a proper solution for the regression the initial mail in this thread
is about ever found? Doesn't look like it for here, but maybe I'm
missing something.

Reminder, the problem afaik is caused by 241d2fb56a ("of: Make OF
framebuffer device names unique") [merged for v6.2-rc8, authored by
Michal Suchanek; committed by Rob Herring].

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke

On 24.04.23 11:35, Helge Deller wrote:
On 4/24/23 11:07, Thomas Zimmermann wrote:
quoted
Am 24.04.23 um 09:33 schrieb Geert Uytterhoeven:
quoted
On Wed, Apr 12, 2023 at 12:05 PM Cyril Brulebois [off-list ref]
wrote:
quoted
Since commit 241d2fb56a18 ("of: Make OF framebuffer device names
unique"),
as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many
"of-display.N" as required.

This means that offb no longer finds the expected device, which
prevents
the Debian Installer from setting up its interface, at least on
ppc64el.

Given the code similarity it is likely to affect ofdrm in the same way.

It might be better to iterate on all possible nodes, but updating the
hardcoded device from "of-display" to "of-display.0" is likely to help
as a first step.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328
Link: https://bugs.debian.org/1033058
Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique")
Cc: stable@vger.kernel.org # v6.2+
Signed-off-by: Cyril Brulebois <redacted>
Thanks for your patch, which is now commit 3a9d8ea2539ebebd
("drm/ofdrm: Update expected device name") in fbdev/for-next.
quoted
--- a/drivers/gpu/drm/tiny/ofdrm.c
+++ b/drivers/gpu/drm/tiny/ofdrm.c
@@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
  static struct platform_driver ofdrm_platform_driver = {
         .driver = {
-               .name = "of-display",
+               .name = "of-display.0",
                 .of_match_table = ofdrm_of_match_display,
         },
         .probe = ofdrm_probe,
Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device
name".

https://lore.kernel.org/r/CAMuHMdVGEeAsmb4tAuuqqGJ-4+BBETwEwYJA+M9NyJv0BJ_hNg@mail.gmail.com (local)
Sorry that I missed this patch. I agree that it's probably not
correct. At least in ofdrm, we want to be able to use multiple
framebuffers at the same time; a feature that has been broken by this
change.
Geert & Thomas, thanks for the review!

I've dropped both patches from fbdev tree for now.
Would be great to find another good solution though, as it breaks the
debian
installer.

Helge
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help