Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into <asm/fb.h>

From
Arnd Bergmann <arnd@arndb.de>
Date
2023-05-11 12:49:36
Also in
dri-devel, linux-arch, linux-m68k, lkml, loongarch, oe-kbuild-all, sparclinux
Reply to
Geert Uytterhoeven, 2023-05-11
On Thu, May 11, 2023, at 14:35, Geert Uytterhoeven wrote:
CC Artur, who's working on HP Jornada 680.

On Wed, May 10, 2023 at 5:55 PM Arnd Bergmann [off-list ref] wrote:
quoted
On Wed, May 10, 2023, at 16:27, Thomas Zimmermann wrote:
quoted
Am 10.05.23 um 16:15 schrieb Arnd Bergmann:
quoted
On Wed, May 10, 2023, at 16:03, kernel test robot wrote:
See also commit 4aafae27d0ce73f8 ("sh: hd64461 tidying."), which
claims they are no longer needed.

Don't the I/O port macros just treat the port as an absolute base address
when sh_io_port_base isn't set?
As far as I can tell, sh_io_port_base gets initialized to '-1'
specifically to prevent that from working by accident. So it's
almost treated as an absolute base address, but the off-by-one
offset ensures this never actually works unless it was first
set to the correct value.

      Arnd
Thread (31 messages) 31 messages, 8 authors, last reply 2023-05-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help