Thread (12 messages) 12 messages, 3 authors, 2023-05-08

Re: [PATCH v3 1/3] Input: ads7846 - Convert to use software nodes

From: Linus Walleij <hidden>
Date: 2023-05-08 21:24:03
Also in: dri-devel, linux-input, linux-mips, linux-mmc, linux-omap, linux-spi, lkml

On Fri, May 5, 2023 at 8:08 PM Dmitry Torokhov
[off-list ref] wrote:
quoted
-     return !gpio_get_value(ts->gpio_pendown);
+     return !gpiod_get_value(ts->gpio_pendown);
This needs to be

        return !gpiod_get_value_raw(ts->gpio_pendown);
There is no such function. The gpio descriptor runpath simply assumes that
device trees can be trusted.
I looked at various DTSes we have and they use a mix of active high and
active low annotations, so we have to go with the "raw" variant for now,
and then update to normal one once we update bad DTSes.
I just sighed and fixed all the device trees :D

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help