Re: [PATCH v3 5/6] fbdev: Move framebuffer I/O helpers into <asm/fb.h>

From
Sam Ravnborg <hidden>
Date
2023-05-03 19:03:40
Also in
dri-devel, linux-arch, linux-arm-kernel, linux-m68k, lkml, loongarch, sparclinux
Reply to
Thomas Zimmermann, 2023-05-03
Hi Thomas,
quoted
But I am missing something somewhere as I cannot see how this builds.
asm-generic now provide the fb_read/fb_write helpers.
But for example sparc has an architecture specifc fb.h so it will not
use the asm-generic variant. So I wonder how sparc get hold of the
asm-generic fb.h file?
All architecture's <asm/fb.h> files include <asm-generic/fb.h>, so that they
all get the interfaces which they don't define themselves. For Sparc, this
is at [1].

Best regards
Thomas


[1]
https://cgit.freedesktop.org/drm/drm-tip/tree/arch/sparc/include/asm/fb.h#n19
quoted
Maybe it is obvious, but I miss it.
OK, it was obvious and I missed it.
I looked at the mainline kernel, and not the drm-tip variant.
Sorry for the noise.

	Sam
Thread (23 messages) 23 messages, 5 authors, last reply 2023-05-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help