Re: [PATCH RESEND 4/4] backlight: tosa: Use backlight helper
From: Sam Ravnborg <hidden>
Date: 2023-01-06 22:26:43
Also in:
dri-devel, lkml
On Fri, Jan 06, 2023 at 05:48:55PM +0100, Stephen Kitt wrote:
Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Signed-off-by: Stephen Kitt <redacted>
I just realized... This driver is about to be deleted by Arnd's effort to remove the PXA platform, so the patch is not relevant and can be ignored. See https://lore.kernel.org/dri-devel/20221019161831.3864786-1-arnd@kernel.org/ (local) Sam
quoted hunk ↗ jump to hunk
--- drivers/video/backlight/tosa_bl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)diff --git a/drivers/video/backlight/tosa_bl.c b/drivers/video/backlight/tosa_bl.c index 77b71f6c19b5..e338b1f00f6a 100644 --- a/drivers/video/backlight/tosa_bl.c +++ b/drivers/video/backlight/tosa_bl.c@@ -50,13 +50,8 @@ static void tosa_bl_set_backlight(struct tosa_bl_data *data, int brightness) static int tosa_bl_update_status(struct backlight_device *dev) { - struct backlight_properties *props = &dev->props; struct tosa_bl_data *data = bl_get_data(dev); - int power = max(props->power, props->fb_blank); - int brightness = props->brightness; - - if (power) - brightness = 0; + int brightness = backlight_get_brightness(dev); tosa_bl_set_backlight(data, brightness);-- 2.30.2