On 11/11/22 10:49, Javier Martinez Canillas wrote:

On 11/8/22 09:16, Thomas Zimmermann wrote:

quoted

Hi

[...]

quoted

My proposal would be to add a little helper to fbdev that includes your
suggestions:

    bool fb_modesetting_disabled(const char *drvname)
    {
       fwonly = video_firmware_drivers_only()
       if (fbonly && drvname)
	pr_warn("")
       return fbonly;
    }

I'm still wondering why you can't simply merge it with what is printed in
  [1] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_nomodeset.c#L18

Other than that, your the proposal is okay, if you adjust your patches to
call this new function "fb_modesetting_disabled()" instead of
calling video_firmware_drivers_only() like this:

+    if (video_firmware_drivers_only())
+        return -ENODEV;

Helge