Thread (32 messages) 32 messages, 12 authors, 2022-12-12

RE: [PATCH 585/606] backlight: adp8860: Convert to i2c's .probe_new()

From: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Date: 2022-11-21 09:46:35
Also in: dri-devel, linux-i2c, lkml

-----Original Message-----
From: Uwe Kleine-König <redacted>
Sent: Freitag, 18. November 2022 23:45
To: Angel Iglesias <redacted>; Lee Jones
[off-list ref]; Grant Likely [off-list ref]; Wolfram
Sang [off-list ref]; Hennerich, Michael
[off-list ref]; Lee Jones [off-list ref]; Daniel
Thompson [off-list ref]; Jingoo Han
[off-list ref]; Helge Deller [off-list ref]
Cc: linux-i2c@vger.kernel.org; kernel@pengutronix.de; Uwe Kleine-König
[off-list ref]; dri-devel@lists.freedesktop.org; linux-
fbdev@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH 585/606] backlight: adp8860: Convert to i2c's .probe_new()


From: Uwe Kleine-König <redacted>

.probe_new() doesn't get the i2c_device_id * parameter, so determine that
explicitly in the probe function.

Signed-off-by: Uwe Kleine-König <redacted>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
quoted hunk ↗ jump to hunk
---
 drivers/video/backlight/adp8860_bl.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/adp8860_bl.c
b/drivers/video/backlight/adp8860_bl.c
index b0fe02273e87..a479aab90f78 100644
--- a/drivers/video/backlight/adp8860_bl.c
+++ b/drivers/video/backlight/adp8860_bl.c
@@ -648,9 +648,9 @@ static const struct attribute_group
adp8860_bl_attr_group = {
 	.attrs = adp8860_bl_attributes,
 };

-static int adp8860_probe(struct i2c_client *client,
-					const struct i2c_device_id *id)
+static int adp8860_probe(struct i2c_client *client)
 {
+	const struct i2c_device_id *id = i2c_client_get_device_id(client);
 	struct backlight_device *bl;
 	struct adp8860_bl *data;
 	struct adp8860_backlight_platform_data *pdata = @@ -803,7 +803,7
@@ static struct i2c_driver adp8860_driver = {
 		.name	= KBUILD_MODNAME,
 		.pm	= &adp8860_i2c_pm_ops,
 	},
-	.probe    = adp8860_probe,
+	.probe_new = adp8860_probe,
 	.remove   = adp8860_remove,
 	.id_table = adp8860_id,
 };
--
2.38.1
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help