[PATCH] fbdev: remove redundant initialization to variable identical

Subsystems: displaylink usb 2.0 framebuffer driver (udlfb), framebuffer layer, the rest

STALE1419d

2 messages, 2 authors, 2022-09-25 · open the first message on its own page

[PATCH] fbdev: remove redundant initialization to variable identical

From: Colin Ian King <hidden>
Date: 2022-09-07 13:51:24

The variable identical is being initialized with a value that is never
read. The variable is being re-assigned later on. The initialization is
redundant and can be removed.

Cleans up clang scan-build warning:
drivers/video/fbdev/udlfb.c:373:6: warning: Value stored to 'identical'
during its initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <redacted>
---
 drivers/video/fbdev/udlfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index c863244ef12c..216d49c9d47e 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -370,7 +370,7 @@ static int dlfb_trim_hline(const u8 *bback, const u8 **bfront, int *width_bytes)
 	const unsigned long *back = (const unsigned long *) bback;
 	const unsigned long *front = (const unsigned long *) *bfront;
 	const int width = *width_bytes / sizeof(unsigned long);
-	int identical = width;
+	int identical;
 	int start = width;
 	int end = width;
 
-- 
2.37.1

Re: [PATCH] fbdev: remove redundant initialization to variable identical

From: Helge Deller <deller@gmx.de>
Date: 2022-09-25 11:12:36

On 9/7/22 15:50, Colin Ian King wrote:
The variable identical is being initialized with a value that is never
read. The variable is being re-assigned later on. The initialization is
redundant and can be removed.

Cleans up clang scan-build warning:
drivers/video/fbdev/udlfb.c:373:6: warning: Value stored to 'identical'
during its initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <redacted>
applied.

Thanks!
Helge
quoted hunk
---
  drivers/video/fbdev/udlfb.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index c863244ef12c..216d49c9d47e 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -370,7 +370,7 @@ static int dlfb_trim_hline(const u8 *bback, const u8 **bfront, int *width_bytes)
  	const unsigned long *back = (const unsigned long *) bback;
  	const unsigned long *front = (const unsigned long *) *bfront;
  	const int width = *width_bytes / sizeof(unsigned long);
-	int identical = width;
+	int identical;
  	int start = width;
  	int end = width;

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help