Re: [PATCH v2 00/10] dt-bindings: iio: use spi-peripheral-props.yaml
From: Krzysztof Kozlowski <hidden>
Date: 2022-08-02 08:01:06
Also in:
linux-devicetree, linux-iio, lkml
From: Krzysztof Kozlowski <hidden>
Date: 2022-08-02 08:01:06
Also in:
linux-devicetree, linux-iio, lkml
On 01/08/2022 18:04, Lukas Wunner wrote:
On Mon, Aug 01, 2022 at 05:45:07PM +0200, Krzysztof Kozlowski wrote:quoted
On 31/07/2022 00:46, Lukas Wunner wrote:quoted
On Wed, Jul 27, 2022 at 06:46:36PM +0200, Krzysztof Kozlowski wrote:quoted
78 files changed, 324 insertions(+), 249 deletions(-)Pardon me for being dense, but what is the benefit of this series that justifies inflating the schema definitions by a total of 75 lines?The commits were explaining rationale, so let me bring it here. The benefits are: This allows using all properties typical for SPI-connected devices, even these which device bindings author did not tried yet.How do you know these untested properties work with the devices to which you're adding them?
These properties should be device independent and instead controller-dependent. At least some of them (that's why CPHA/CPOL was moved away and maybe the same we need to do with spi-3wire, spi-cs-high, spi-lsb-first). My approach here is no different than other subsystems. Take a look at regulator - we allow all regulator.yaml properties, even though several are not applicable (e.g. current for voltage regulators) and for sure no tested. Best regards, Krzysztof