Re: [PATCH 5/5] fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible()
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2022-06-30 19:21:51
Also in:
dri-devel
Hi Helge, On Wed, Jun 29, 2022 at 10:00 PM Helge Deller [off-list ref] wrote:
Use the fbcon_info_from_console() wrapper which was added to kernel
v5.19 with commit 409d6c95f9c6 ("fbcon: Introduce wrapper for console->fb_info lookup").
Signed-off-by: Helge Deller <deller@gmx.de>Thanks for your patch! I guess you kept this separate, to ease backporting? This does mean that upstream will never really see if using registered_fb[] directly may cause problems...
quoted hunk ↗ jump to hunk
--- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c@@ -2752,7 +2752,7 @@ int fbcon_modechange_possible(struct fb_info *info, struct fb_var_screeninfo *va for (i = first_fb_vc; i <= last_fb_vc; i++) { vc = vc_cons[i].d; if (!vc || vc->vc_mode != KD_TEXT || - registered_fb[con2fb_map[i]] != info) + fbcon_info_from_console(i) != info) continue; if (vc->vc_font.width > FBCON_SWAP(var->rotate, var->xres, var->yres) ||
Anyway, LGTM, so
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds