Re: [PATCH v2 13/15] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support
From: Randy Dunlap <hidden>
Date: 2022-06-13 20:59:31
Also in:
dri-devel, linux-arm-kernel, linux-devicetree, linux-iio, linux-leds, linux-mediatek, linux-pm, linux-usb, lkml
Hi-- On 6/13/22 04:11, ChiaEn Wu wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 6090e647daee..61e6ec416cb0 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig@@ -244,6 +244,17 @@ config LEDS_MT6323 This option enables support for on-chip LED drivers found on Mediatek MT6323 PMIC. +config LEDS_MT6370_RGB + tristate "LED Support for Mediatek MT6370 PMIC" + depends on LEDS_CLASS + depends on MFD_MT6370 + select LINEAR_RANGE + help + Say Y here to enable support for MT6370_RGB LED device. + In MT6370, there're four channel current-sink LED driver that support
Please spell out "there are" instead of using an unusual contraction. Also: drivers that support
+ hardware pattern for reg, pwm, breath mode. Isink4 channel
PWM, What is "reg"?
+ can also be used as a CHG_VIN power good indicator.
-- ~Randy