Re: [PATCH v5 7/7] fbdev: Make registered_fb[] private to fbmem.c
From: Sam Ravnborg <hidden>
Date: 2022-05-11 17:01:09
Also in:
dri-devel, linux-staging, lkml
Hi Javier. On Wed, May 11, 2022 at 01:32:30PM +0200, Javier Martinez Canillas wrote:
From: Daniel Vetter <redacted> Well except when the olpc dcon fbdev driver is enabled, that thing digs around in there in rather unfixable ways. Cc oldc_dcon maintainers as fyi.
Another way to fix this is to mark FB_OLPC_DCON and add a TODO entry to fix this. We are really not supposed to carry such special code around to keep staging working. I know this may not be a popular viewpoint, but just look at the ugly workarounds required here. Sam
quoted hunk ↗ jump to hunk
v2: I typoed the config name (0day) Cc: kernel test robot <redacted> Cc: Jens Frederich <redacted> Cc: Jon Nettleton <redacted> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-staging@lists.linux.dev Signed-off-by: Daniel Vetter <redacted> Signed-off-by: Daniel Vetter <redacted> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Cc: Daniel Vetter <redacted> Cc: Helge Deller <deller@gmx.de> Cc: Matthew Wilcox <willy@infradead.org> Cc: Sam Ravnborg <redacted> Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> Cc: Zhen Lei <redacted> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Xiyu Yang <redacted> Cc: linux-fbdev@vger.kernel.org Cc: Zheyu Ma <redacted> Cc: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> --- (no changes since v1) drivers/video/fbdev/core/fbmem.c | 8 ++++++-- include/linux/fb.h | 7 +++---- 2 files changed, 9 insertions(+), 6 deletions(-)diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 265efa189bcc..6cab5f4c1fb3 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c@@ -50,10 +50,14 @@ static DEFINE_MUTEX(registration_lock); struct fb_info *registered_fb[FB_MAX] __read_mostly; -EXPORT_SYMBOL(registered_fb); - int num_registered_fb __read_mostly; +#if IS_ENABLED(CONFIG_FB_OLPC_DCON) +EXPORT_SYMBOL(registered_fb); EXPORT_SYMBOL(num_registered_fb); +#endif
It is stuff like this I refer to as "ugly" in the comment above. Sam