Thread (29 messages) 29 messages, 4 authors, 2022-05-11

Re: [PATCH v3 3/4] fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove

From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2022-05-06 13:18:55
Also in: dri-devel, lkml

Hello Andrzej,

On 5/6/22 15:07, Andrzej Hajda wrote:
On 06.05.2022 00:05, Javier Martinez Canillas wrote:
[snip]
quoted
+
+	framebuffer_release(info);
+
  	if (request_mem_succeeded)
  		release_mem_region(info->apertures->ranges[0].base,
  				   info->apertures->ranges[0].size);
You are releasing info, then you are using it.

I suspect it is responsible for multiple failures of Intel CI [1].
Yes, it is :( sorry about the mess. Ville already reported this to me.
I'll post a patch in a minute.
 
I wonder how this didn't happen before since .remove() happens before
.fb_destroy() AFAIU...

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help