Re: [PATCH 17/48] ARM: pxa: corgi: use gpio descriptors for audio

Linus Walleij · 2022-05-01T23:35:26+0200

On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The audio driver should not use a hardwired gpio number > from the header. Change it to use a lookup table. > > Acked-by: Mark Brown > Cc: alsa-devel@alsa-project.org > Acked-by: Robert Jarzmik > Signed-off-by: Arnd Bergmann Looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij

[PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 01/48] ARM: pxa: split mach/generic.h · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 02/48] ARM: pxa: make mainstone.h private · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 04/48] ARM: pxa: remove mach/dma.h · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 03/48] ARM: pxa: make mach/regs-uart.h private · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 10/48] ARM: pxa: pxa2xx-ac97-lib: use IRQ resource · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 08/48] ARM: pxa: move regs-lcd.h into driver · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 13/48] ARM: pxa: use pdev resource for palmld mmio · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
Re: [PATCH 13/48] ARM: pxa: use pdev resource for palmld mmio · Damien Le Moal <hidden> · 2022-04-19
[PATCH 09/48] watchdog: sa1100: use platform device registration · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
Re: [PATCH 09/48] watchdog: sa1100: use platform device registration · Guenter Roeck <linux@roeck-us.net> · 2022-04-19
[PATCH 05/48] ARM: pxa: split up mach/hardware.h · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 27/48] input: touchscreen: mainstone: sync with zylonite driver · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio · Linus Walleij <hidden> · 2022-05-01
Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio · Arnd Bergmann <arnd@kernel.org> · 2022-05-02
Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio · Linus Walleij <hidden> · 2022-05-04
Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio · Arnd Bergmann <arnd@kernel.org> · 2022-05-05
Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio · Linus Walleij <hidden> · 2022-05-05
Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio · Mark Brown <broonie@kernel.org> · 2022-05-05
Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio · Arnd Bergmann <arnd@kernel.org> · 2022-05-05
Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio · Mark Brown <broonie@kernel.org> · 2022-05-05
Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio · Arnd Bergmann <arnd@kernel.org> · 2022-05-05
[PATCH 37/48] ARM: pxa: move smemc register access from clk to platform · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 19/48] ARM: pxa: lubbock: pass udc irqs as resource · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 36/48] cpufreq: pxa3: move clk register access to clk driver · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 06/48] ARM: pxa: stop using mach/bitfield.h · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 45/48] ARM: PXA: fix multi-cpu build of xsc3 · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 35/48] ARM: pxa: remove get_clk_frequency_khz() · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 11/48] ARM: pxa: move pcmcia board data into mach-pxa · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 22/48] ARM: pxa: z2: use gpio lookup for audio device · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
Re: [PATCH 22/48] ARM: pxa: z2: use gpio lookup for audio device · Linus Walleij <hidden> · 2022-05-01
[PATCH 21/48] ARM: pxa: eseries: use gpio lookup for audio · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
Re: [PATCH 21/48] ARM: pxa: eseries: use gpio lookup for audio · Linus Walleij <hidden> · 2022-05-01
[PATCH 12/48] ARM: pxa: make addr-map.h header local · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 33/48] ASoC: pxa: i2s: use normal MMIO accessors · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 16/48] ARM: pxa: poodle: use platform data for poodle asoc driver · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 17/48] ARM: pxa: corgi: use gpio descriptors for audio · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
Re: [PATCH 17/48] ARM: pxa: corgi: use gpio descriptors for audio · Linus Walleij <hidden> · 2022-05-01
[PATCH 24/48] ARM: pxa: mainstone-wm97xx: use gpio lookup table · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
Re: [PATCH 24/48] ARM: pxa: mainstone-wm97xx: use gpio lookup table · Linus Walleij <hidden> · 2022-05-01
[PATCH 28/48] Input: touchscreen: use wrapper for pxa2xx ac97 registers · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 30/48] Input: wm97xx - get rid of irq_enable method in wm97xx_mach_ops · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 42/48] ARM: mmp: remove tavorevb board support · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 26/48] input: touchscreen: mainstone: fix pxa2xx+pxa3xx configuration · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 25/48] ARM: pxa: zylonite: use gpio lookup instead mfp header · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
Re: [PATCH 25/48] ARM: pxa: zylonite: use gpio lookup instead mfp header · Linus Walleij <hidden> · 2022-05-01
[PATCH 31/48] ASoC: pxa: use pdev resource for FIFO regs · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 39/48] power: tosa: simplify probe function · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 15/48] ARM: pxa: tosa: use gpio descriptor for audio · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
Re: [PATCH 15/48] ARM: pxa: tosa: use gpio descriptor for audio · Linus Walleij <hidden> · 2022-05-01
[PATCH 47/48] ARM: pxa: remove support for MTD_XIP · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 29/48] Input: wm97xx - switch to using threaded IRQ · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 48/48] ARM: pxa: convert to multiplatform · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 23/48] ARM: pxa: magician: use platform driver for audio · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
Re: [PATCH 23/48] ARM: pxa: magician: use platform driver for audio · Linus Walleij <hidden> · 2022-05-01
[PATCH 41/48] ARM: pxa: remove unused mach/bitfield.h · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 44/48] ARM: pxa: move plat-pxa to drivers/soc/ · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 32/48] ASoC: pxa: ac97: use normal MMIO accessors · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 34/48] ARM: pxa: pcmcia: move smemc configuration back to arch · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 20/48] ARM: pxa: spitz: use gpio descriptors for audio · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
Re: [PATCH 20/48] ARM: pxa: spitz: use gpio descriptors for audio · Linus Walleij <hidden> · 2022-05-01
[PATCH 07/48] ARM: pxa: move mach/sound.h to linux/platform_data/ · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 46/48] ARM: pxa: move mach/*.h to mach-pxa/ · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 14/48] ARM: pxa: maybe fix gpio lookup tables · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 38/48] ARM: pxa: move clk register definitions to driver · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
[PATCH 40/48] ARM: pxa: tosa: use gpio lookup for battery · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
Re: [PATCH 40/48] ARM: pxa: tosa: use gpio lookup for battery · Sebastian Reichel <sre@kernel.org> · 2022-04-20
Re: [PATCH 40/48] ARM: pxa: tosa: use gpio lookup for battery · Arnd Bergmann <arnd@kernel.org> · 2022-04-20
Re: [PATCH 40/48] ARM: pxa: tosa: use gpio lookup for battery · Linus Walleij <hidden> · 2022-05-07
[PATCH 43/48] ARM: mmp: rename pxa_register_device · Arnd Bergmann <arnd@kernel.org> · 2022-04-19
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@arndb.de> · 2022-04-21
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-04-22
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@kernel.org> · 2022-04-22
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-04-22
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@kernel.org> · 2022-04-22
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-04-22
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-04-22
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@kernel.org> · 2022-04-23
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-04-24
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@kernel.org> · 2022-04-24
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-04-24
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@kernel.org> · 2022-04-24
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@arndb.de> · 2022-04-28
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-04-28
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-04-29
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-04-29
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@arndb.de> · 2022-04-29
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-04-29
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@arndb.de> · 2022-04-30
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-04-30
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@arndb.de> · 2022-04-30
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@arndb.de> · 2022-04-30
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-05-02
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@arndb.de> · 2022-05-02
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-05-02
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@arndb.de> · 2022-05-02
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-05-03
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@arndb.de> · 2022-05-03
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Guenter Roeck <linux@roeck-us.net> · 2022-05-03
Re: [PATCH v2 00/48] ARM: PXA multiplatform support · Arnd Bergmann <arnd@arndb.de> · 2022-05-03

From: Linus Walleij <hidden>
Date: 2022-05-01 21:35:48
Also in: dri-devel, linux-arm-kernel, linux-clk, linux-ide, linux-input, linux-leds, linux-mips, linux-mmc, linux-pm, linux-rtc, linux-usb, lkml

On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann [off-list ref] wrote:

From: Arnd Bergmann <arnd@arndb.de>

The audio driver should not use a hardwired gpio number
from the header. Change it to use a lookup table.

Acked-by: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Looks good to me!
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help