Thread (2 messages) 2 messages, 2 authors, 2022-04-11

Re: [PATCH] fbdev: i740fb: use memset_io() to clear screen

From: Helge Deller <deller@gmx.de>
Date: 2022-04-11 06:18:32
Also in: dri-devel, lkml

On 4/10/22 22:28, Ondrej Zary wrote:
sparse complains that using memset() on __iomem pointer is wrong:
incorrect type in argument 1 (different address spaces)

Use memset_io() to clear screen instead.

Tested on real i740 cards.

Signed-off-by: Ondrej Zary <redacted>
applied.
Thanks!

Helge

quoted hunk ↗ jump to hunk
---
 drivers/video/fbdev/i740fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c
index 52cce0db8bd3..dd45ea8203be 100644
--- a/drivers/video/fbdev/i740fb.c
+++ b/drivers/video/fbdev/i740fb.c
@@ -740,7 +740,7 @@ static int i740fb_set_par(struct fb_info *info)
 	if (i)
 		return i;

-	memset(info->screen_base, 0, info->screen_size);
+	memset_io(info->screen_base, 0, info->screen_size);

 	vga_protect(par);
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help