Thread (49 messages) 49 messages, 7 authors, 2022-04-07

Re: [PATCH v2 06/19] fbcon: Use delayed work for cursor

From: Daniel Vetter <hidden>
Date: 2022-04-06 02:32:42
Also in: dri-devel, intel-gfx, lkml

On Thu, Feb 10, 2022 at 08:43:36PM +0900, Tetsuo Handa wrote:
On 2022/02/09 6:08, Daniel Vetter wrote:
quoted
@@ -714,6 +700,8 @@ static int con2fb_acquire_newinfo(struct vc_data *vc, struct fb_info *info,
 		ops = kzalloc(sizeof(struct fbcon_ops), GFP_KERNEL);
 		if (!ops)
 			err = -ENOMEM;
+
+		INIT_DELAYED_WORK(&ops->cursor_work, fb_flashcursor);
 	}
 
 	if (!err) {
Memory allocation fault injection will hit NULL pointer dereference.
The error handling here is convoluted and I got this wrong, but a later
patch to extract an fbcon_open() helper fixes it. I'll fix this small
bisect issue for v3 anyway, thanks for taking a look at the patches.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help