Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

Hello Geert,

On 3/9/22 13:56, Geert Uytterhoeven wrote:

Hi Javier,

On Wed, Mar 9, 2022 at 1:14 PM Javier Martinez Canillas
[off-list ref] wrote:

quoted

On 3/8/22 17:30, Geert Uytterhoeven wrote:

quoted

Unfortunately a regression was introduced since your v3: printed
text is mirrored upside-down. I.e. "E" is rendered correctly, but "L"
turns into "Γ" (Greek Gamma).
I suspect something went wrong with the display initialization
sequence.

Could you please try Chen-Yu's fix for the COM scan direction mask ?

https://lists.freedesktop.org/archives/dri-devel/2022-March/345915.html

I made a mistake when converting to use the GENMASK() and FIELD_PREP()
macros in v4 as suggested by Andy. The SSD130X_SET_COM_SCAN_DIR_MASK
wasn't correct which would explain the output to be vertically flipped.

Thanks, confirmed fixed.

Great, thanks a lot for testing and the confirmation!

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat