Thread (82 messages) 82 messages, 15 authors, 2022-02-08

Re: [PATCH 11/21] fbcon: Extract fbcon_open/release helpers

From: Sam Ravnborg <hidden>
Date: 2022-02-06 00:48:48
Also in: dri-devel, intel-gfx, lkml

Hi Daniel,
quoted
+	kfree(ops->cursor_state.mask);
+	kfree(ops->cursor_data);
+	kfree(ops->cursor_src);
+	kfree(ops->fontbuffer);
+	kfree(oldinfo->fbcon_par);
+	oldinfo->fbcon_par = NULL;
These all look like candidates to stuff into fbcon_release()
That would drop the nice symmetry but make it more consistent.

I think we miss freeing ops->cursor_data in fbcon_exit(),
but I did not follow all the code.
We agree as I can see this was done in a later patch.

	Sam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help