Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

From
Javier Martinez Canillas <javierm@redhat.com>
Date
2022-01-31 23:38:07
Also in
dri-devel, linux-pwm, lkml
On 1/31/22 21:56, Sam Ravnborg wrote:
Hi Javier,
On Mon, Jan 31, 2022 at 09:12:20PM +0100, Javier Martinez Canillas wrote:
quoted
This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306,
SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver.

Using the DRM fb emulation, all the tests from Geert Uytterhoeven's fbtest
(https://git.kernel.org/pub/scm/linux/kernel/git/geert/fbtest.git) passes:
Impressed how fast you did this!
Saw the picture you posted a link to on irc - nice.
Thanks :)

What's impressive is how many helper functions the DRM core has, so typing a
new DRM driver is something that could be achieved in a few hours. Which was
one of my goals with this experiment, to understand how much effort would be
for a developer with no prior experience with DRM to port a fbdev driver.
 
quoted
Patch #3 adds the driver. The name ssd1307 was used instead of ssd130x
(which would be more accurate) to avoid confusion for users who want to
migrate from the existing ssd1307fb fbdev driver.
Looking forward the name ssd130x would make more sense. There is only so
many existing users and a potential of much more new users.
So in my color of the world the naming that benefits the most users
wins.
Agreed. That's also what Andy suggested and makes a lot of sense to me.
 
	Sam
Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat
Thread (1 message) 1 message, 1 author, last reply 2022-01-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help