Re: [PATCH 5/5] spi: make remove callback a void function

From
Geert Uytterhoeven <geert@linux-m68k.org>
Date
2022-01-25 10:47:12
Also in
alsa-devel, dri-devel, linux-can, linux-clk, linux-gpio, linux-hwmon, linux-iio, linux-input, linux-integrity, linux-leds, linux-media, linux-mmc, linux-omap, linux-rtc, linux-serial, linux-spi, linux-staging, linux-usb, linux-wireless, lkml, netdev, platform-driver-x86
On Sun, Jan 23, 2022 at 6:54 PM Uwe Kleine-König
[off-list ref] wrote:
The value returned by an spi driver's remove function is mostly ignored.
(Only an error message is printed if the value is non-zero that the
error is ignored.)

So change the prototype of the remove function to return no value. This
way driver authors are not tempted to assume that passing an error to
the upper layer is a good idea. All drivers are adapted accordingly.
There is no intended change of behaviour, all callbacks were prepared to
return 0 before.

Signed-off-by: Uwe Kleine-König <redacted>
 drivers/spi/spi-slave-system-control.c                |  3 +--
 drivers/spi/spi-slave-time.c                          |  3 +--
 drivers/spi/spi.c                                     | 11 ++---------
 drivers/spi/spidev.c                                  |  4 +---
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Thread (1 message) 1 message, 1 author, last reply 2022-01-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help