[PATCH v2 06/13] backlight: qcom-wled: Remove unnecessary 4th default string in WLED3
flat view
STALE1826d
REVIEWED: 2 (0M)
From: Marijn Suijten <marijn.suijten@somainline.org>
Date: 2021-10-07 21:34:27
Also in:
dri-devel, linux-arm-msm, lkml, phone-devel
Subsystem:
arm/qualcomm mailing list, backlight class/subsystem, framebuffer layer, the rest · Maintainers:
Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller, Linus Torvalds
Revision v2 of 4 in this series; 2 review trailers.
Revisions (4)
- v1 [diff vs current]
- v2 current
- v2 [diff vs current]
- v3 [diff vs current]
The previous commit improves num_strings parsing to not go over the maximum of 3 strings for WLED3 anymore. Likewise this default index for a hypothetical 4th string is invalid and could access registers that are not mapped to the desired purpose. Removing this value gets rid of undesired confusion and avoids the possibility of accessing registers at this offset even if the 4th array element is used by accident. Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> Reviewed-by: AngeloGioacchino Del Regno <redacted> Reviewed-by: Daniel Thompson <redacted> --- drivers/video/backlight/qcom-wled.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
index 9bfbf601762a..c342cd8440e1 100644
--- a/drivers/video/backlight/qcom-wled.c
+++ b/drivers/video/backlight/qcom-wled.c@@ -946,7 +946,7 @@ static const struct wled_config wled3_config_defaults = { .cs_out_en = false, .ext_gen = false, .cabc = false, - .enabled_strings = {0, 1, 2, 3}, + .enabled_strings = {0, 1, 2}, }; static int wled4_setup(struct wled *wled)
--
2.33.0