[PATCH v2 00/34] component: Make into an aggregate bus
flat view
STALE1839d
SUPERSEDED
From: Stephen Boyd <hidden>
Date: 2021-10-06 19:38:28
Also in:
dri-devel, linux-arm-msm, linux-omap, linux-pm, lkml
Subsystem:
ab8500 battery and charger drivers, arm hdlcd drm driver, arm komeda drm-kms driver, arm mali-dp drm driver, arm/rockchip soc support, char and misc drivers, driver component framework, driver core, kobjects, debugfs and sysfs, drm driver for st-ericsson mcde, drm driver for qualcomm display hardware, drm drivers, drm drivers and misc gpu patches, drm drivers for allwinner a10, drm drivers for amlogic socs, drm drivers for exynos, drm drivers for mediatek, drm drivers for rockchip, drm drivers for ti lcdc, drm drivers for ti omap, drm drivers for vc4, drm drivers for vivante gpu ip, framebuffer layer, ingenic jz47xx socs, intel management engine (mei), iommu subsystem, marvell armada drm support, mediatek iommu driver, omap display subsystem and framebuffer support (dss2), power supply class/subsystem and drivers, qcom audio (asoc) drivers, sound, sound - soc layer / dynamic audio power management (asoc), the rest · Maintainers:
Linus Walleij, Liviu Dudau, Heiko Stuebner, Arnd Bergmann, Greg Kroah-Hartman, "Rafael J. Wysocki", Danilo Krummrich, Johan Hovold, Rob Clark, Dmitry Baryshkov, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Chen-Yu Tsai, Neil Armstrong, Inki Dae, Seung-Woo Kim, Kyungmin Park, Chun-Kuang Hu, Philipp Zabel, Sandy Huang, Andy Yan, Jyri Sarha, Tomi Valkeinen, Dave Stevenson, Lucas Stach, Helge Deller, Paul Cercueil, Alexander Usyskin, Joerg Roedel, Will Deacon, Russell King, Yong Wu, Sebastian Reichel, Srinivas Kandagatla, Jaroslav Kysela, Takashi Iwai, Liam Girdwood, Mark Brown, Linus Torvalds
Status: Superseded by v6 (posted 2022-01-27). [go to v6]
Revision v2 (6 revisions archived).
Revisions (6)
This series is from discussion we had on reordering the device lists for
drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put
the aggregate device onto and then we probe the aggregate device once
all the components are probed and call component_add(). The probe/remove
hooks are where the bind/unbind calls go, and then a shutdown hook is
added that can be used to shutdown the drm display pipeline at the right
time.
This works for me on my sc7180 board. I no longer get a warning from i2c
at shutdown that we're trying to make an i2c transaction after the i2c
bus has been shutdown. There's more work to do on the msm drm driver to
extract component device resources like clks, regulators, etc. out of
the component bind function into the driver probe but I wanted to move
everything over now in other component drivers before tackling that
problem.
I'll definitely be sending a v3 so this is partially a request for
testing to shake out any more problems. Tested-by tags would be appreciated,
and Acked-by/Reviewed-by tags too. I sent this to gregkh which may be
incorrect but I don't know what better tree to send it all through.
Maybe drm?
I'll be faster at resending this next time, sorry for the long delay!
Changes since v1 (https://lore.kernel.org/r/20210520002519.3538432-1-swboyd@chromium.org (local)):
- Use devlink to connect components to the aggregate device
- Don't set the registering device as a parent of the aggregate device
- New patch for bind_component/unbind_component ops that takes the
aggregate device
- Convert all drivers in the tree to use the aggregate driver approach
- Allow one aggregate driver to be used for multiple aggregate devices
[1] https://lore.kernel.org/r/20210508074118.1621729-1-swboyd@chromium.org (local)
Stephen Boyd (34):
component: Introduce struct aggregate_device
component: Introduce the aggregate bus_type
component: Move struct aggregate_device out to header file
drm/msm: Migrate to aggregate driver
component: Add {bind,unbind}_component() ops that take aggregate
device
drm/of: Add a drm_of_aggregate_probe() API
drm/komeda: Migrate to aggregate driver
drm/arm/hdlcd: Migrate to aggregate driver
drm/malidp: Migrate to aggregate driver
drm/armada: Migrate to aggregate driver
drm/etnaviv: Migrate to aggregate driver
drm/kirin: Migrate to aggregate driver
drm/exynos: Migrate to aggregate driver
drm/imx: Migrate to aggregate driver
drm/ingenic: Migrate to aggregate driver
drm/mcde: Migrate to aggregate driver
drm/mediatek: Migrate to aggregate driver
drm/meson: Migrate to aggregate driver
drm/omap: Migrate to aggregate driver
drm/rockchip: Migrate to aggregate driver
drm/sti: Migrate to aggregate driver
drm/sun4i: Migrate to aggregate driver
drm/tilcdc: Migrate to aggregate driver
drm/vc4: Migrate to aggregate driver
drm/zte: Migrate to aggregate driver
iommu/mtk: Migrate to aggregate driver
mei: Migrate to aggregate driver
power: supply: ab8500: Migrate to aggregate driver
fbdev: omap2: Migrate to aggregate driver
sound: hdac: Migrate to aggregate driver
ASoC: codecs: wcd938x: Migrate to aggregate driver
component: Get rid of drm_of_component_probe()
component: Remove component_master_ops and friends
component: Remove all references to 'master'
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Benjamin Gaignard <redacted>
Cc: Chen Feng <redacted>
Cc: Chen-Yu Tsai <redacted>
Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Daniel Vetter <redacted>
Cc: Emma Anholt <redacted>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Heiko Stübner" <heiko@sntech.de>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: James Qian Wang (Arm Technology China) <redacted>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: John Stultz <redacted>
Cc: Joonyoung Shim <redacted>
Cc: Jyri Sarha <jyri.sarha@iki.fi>
Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: <redacted>
Cc: <redacted>
Cc: <redacted>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Mark Brown <broonie@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Neil Armstrong <redacted>
Cc: Paul Cercueil <paul@crapouillou.net>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Rob Clark <redacted>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Russell King <linux+etnaviv@armlinux.org.uk>
Cc: Russell King <redacted>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: Saravana Kannan <redacted>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: Tian Tao <tiantao6@hisilicon.com>
Cc: Tomas Winkler <redacted>
Cc: Tomi Valkeinen <tomba@kernel.org>
Cc: Will Deacon <will@kernel.org>
Cc: Xinliang Liu <xinliang.liu@linaro.org>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Yong Wu <yong.wu@mediatek.com>
drivers/base/component.c | 555 +++++++++++-------
.../gpu/drm/arm/display/komeda/komeda_drv.c | 20 +-
drivers/gpu/drm/arm/hdlcd_drv.c | 21 +-
drivers/gpu/drm/arm/malidp_drv.c | 21 +-
drivers/gpu/drm/armada/armada_drv.c | 23 +-
drivers/gpu/drm/drm_drv.c | 2 +-
drivers/gpu/drm/drm_of.c | 20 +-
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 20 +-
drivers/gpu/drm/exynos/exynos_drm_drv.c | 21 +-
.../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 20 +-
drivers/gpu/drm/imx/imx-drm-core.c | 20 +-
drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 24 +-
drivers/gpu/drm/mcde/mcde_drv.c | 23 +-
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 20 +-
drivers/gpu/drm/meson/meson_drv.c | 21 +-
drivers/gpu/drm/msm/msm_drv.c | 46 +-
drivers/gpu/drm/omapdrm/dss/dss.c | 17 +-
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 20 +-
drivers/gpu/drm/sti/sti_drv.c | 20 +-
drivers/gpu/drm/sun4i/sun4i_drv.c | 26 +-
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 28 +-
drivers/gpu/drm/vc4/vc4_drv.c | 20 +-
drivers/gpu/drm/zte/zx_drm_drv.c | 20 +-
drivers/iommu/mtk_iommu.c | 14 +-
drivers/iommu/mtk_iommu.h | 6 +-
drivers/iommu/mtk_iommu_v1.c | 14 +-
drivers/misc/mei/hdcp/mei_hdcp.c | 22 +-
drivers/power/supply/ab8500_charger.c | 22 +-
drivers/video/fbdev/omap2/omapfb/dss/dss.c | 20 +-
include/drm/drm_of.h | 9 +-
include/linux/component.h | 92 ++-
sound/hda/hdac_component.c | 21 +-
sound/soc/codecs/wcd938x.c | 20 +-
33 files changed, 780 insertions(+), 488 deletions(-)
base-commit: e4e737bb5c170df6135a127739a9e6148ee3da82
--
https://chromeos.dev