[PATCH 03/10] backlight: qcom-wled: Override num-strings when enabled-strings is set
flat view
STALE1828d
REVIEWED: 1 (0M)
From: Marijn Suijten <marijn.suijten@somainline.org>
Date: 2021-10-04 19:27:57
Also in:
dri-devel, linux-arm-msm, lkml, phone-devel
Subsystem:
arm/qualcomm mailing list, backlight class/subsystem, framebuffer layer, the rest · Maintainers:
Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller, Linus Torvalds
Revision v1 of 4 in this series; 1 review trailer.
Revisions (4)
- v1 current
- v2 [diff vs current]
- v2 [diff vs current]
- v3 [diff vs current]
DT-bindings do not specify num-strings as mandatory property, yet it is
required to be specified even if enabled-strings is used. The length of
that property-array should already be enough to determine exactly which
and how many strings to enable.
Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3")
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: AngeloGioacchino Del Regno <redacted>
---
drivers/video/backlight/qcom-wled.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
index 9927ed98944a..29910e603c42 100644
--- a/drivers/video/backlight/qcom-wled.c
+++ b/drivers/video/backlight/qcom-wled.c@@ -1536,6 +1536,8 @@ static int wled_configure(struct wled *wled) string_len, rc); return -EINVAL; } + + cfg->num_strings = string_len; } return 0;
--
2.33.0