Thread (10 messages) 10 messages, 3 authors, 2021-07-31

Re: [PATCH v2 3/3] staging/fbtft: Fix braces coding style

From: Len Baker <hidden>
Date: 2021-07-25 14:02:29
Also in: dri-devel, linux-staging, lkml

Hi,

On Sat, Jul 24, 2021 at 08:01:53PM +0200, Geert Uytterhoeven wrote:
Hi Len,

On Sat, Jul 24, 2021 at 7:44 PM Len Baker [off-list ref] wrote:
quoted
Add braces to the "for" loop and remove braces from the "if" statement.
This way the kernel coding style is followed.

Signed-off-by: Len Baker <redacted>
Thanks for your patch!
quoted
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
quoted
@@ -1016,10 +1018,9 @@ int fbtft_init_display(struct fbtft_par *par)

        i = 0;
        while (i < FBTFT_MAX_INIT_SEQUENCE) {
-               if (par->init_sequence[i] == -3) {
-                       /* done */
-                       return 0;
-               }
These braces should not be removed, due to the presence of
the comment.
Ok, I leave it as is.

Thanks,
Len
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help