Hi Maxime,
On Tue, May 18, 2021 at 4:33 PM Maxime Ripard [off-list ref] wrote:
On Tue, May 18, 2021 at 09:51:31AM +0200, Geert Uytterhoeven wrote:
quoted
Convert the Solomon SSD1307 Framebuffer Device Tree binding
documentation to json-schema.
Fix the spelling of the "pwms" property.
Document default values.
Make properties with default values not required.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
I have listed Maxime as the maintainer, as he wrote the original driver
and bindings. Maxime: Please scream if this is inappropriate ;-)
Fine by me :)
Thanks!
quoted
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
quoted
+ solomon,dclk-div:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 1
+ maximum: 16
+ description:
+ Clock divisor. The default value is controller-dependent.
I guess we could document the default using an if / else statement?
While clk-div has only two different defaults, dclk-frq has different
defaults for each of the 4 variants supported.
Do you think it's worthwhile doing that? All upstream DTS files lack
these properties, thus use the default values.
Looks good otherwise :)
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds