Re: [PATCH v2] tty: vt: always invoke vc->vc_sw->con_resize callback
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
Date: 2021-05-15 16:33:18
Also in:
dri-devel, lkml
On Sat, 15 May 2021, Maciej W. Rozycki wrote:
On Sat, 15 May 2021, Tetsuo Handa wrote:quoted
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 3406067985b1..22bb3892f6bd 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c@@ -2019,7 +2019,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned int width, return -EINVAL; pr_debug("resize now %ix%i\n", var.xres, var.yres); - if (con_is_visible(vc)) { + if (con_is_visible(vc) && vc->vc_mode == KD_TEXT) { var.activate = FB_ACTIVATE_NOW | FB_ACTIVATE_FORCE; fb_set_var(info, &var);LGTM, although I'll yet try to verify it with hardware. But it'll have to wait another week or so as I'm currently away from my lab and this requires physical presence.
NB I suggest that you request your change to be backported, i.e. post v3
with:
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org # v2.6.12+
Maciej