Thread (3 messages) 3 messages, 2 authors, 2021-04-07

Re: [PATCH] staging: sm750fb: Convert camel case to snake case

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-04-06 09:37:29
Also in: linux-staging, lkml

On Tue, Apr 06, 2021 at 02:18:41AM -0700, Pavle Rohalj wrote:
-	struct dvi_ctrl_device *pCurrentDviCtrl;
+	struct dvi_ctrl_device *p_current_dvi_ctrl;
Does this change make sense?  Why keep the "p_" here?  We do not need or
use, this type of variable naming in the kernel.

Also, please break this up into a patch series where you do one
structure change at a time.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help