[PATCH] staging: fbtft: fix a typo

Subsystems: fbtft framebuffer drivers, staging subsystem, the rest

STALE1973d

5 messages, 2 authors, 2021-03-26 · open the first message on its own page

[PATCH] staging: fbtft: fix a typo

From: Carlis <hidden>
Date: 2021-03-26 08:06:05

From: "Carlis" <redacted>

Change 'tft' to 'TFT'

Signed-off-by: Carlis <redacted>
---
 drivers/staging/fbtft/fbtft-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 4f362da..44e7acb 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -775,7 +775,7 @@ void fbtft_framebuffer_release(struct fb_info *info)
 EXPORT_SYMBOL(fbtft_framebuffer_release);
 
 /**
- *	fbtft_register_framebuffer - registers a tft frame buffer device
+ *	fbtft_register_framebuffer - registers a TFT frame buffer device
  *	@fb_info: frame buffer info structure
  *
  *  Sets SPI driverdata if needed
@@ -873,7 +873,7 @@ int fbtft_register_framebuffer(struct fb_info *fb_info)
 EXPORT_SYMBOL(fbtft_register_framebuffer);
 
 /**
- *	fbtft_unregister_framebuffer - releases a tft frame buffer device
+ *	fbtft_unregister_framebuffer - releases a TFT frame buffer device
  *	@fb_info: frame buffer info structure
  *
  *  Frees SPI driverdata if needed
-- 
1.9.1

Re: [PATCH] staging: fbtft: fix a typo

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-03-26 08:38:28

On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote:
From: "Carlis" <redacted>

Change 'tft' to 'TFT'
Why?  What is wrong with "tft"?
Signed-off-by: Carlis <redacted>
Full name please.

thanks,

greg k-h

Re: [PATCH] staging: fbtft: fix a typo

From: carlis <hidden>
Date: 2021-03-26 09:17:26

On Fri, 26 Mar 2021 09:37:48 +0100
Greg KH [off-list ref] wrote:
On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote:
quoted
From: "Carlis" <redacted>

Change 'tft' to 'TFT'  
Why?  What is wrong with "tft"?
I think abbreviations should be capitalized.
quoted
Signed-off-by: Carlis <redacted>  
Full name please.
OK, i will use my full name next patch
thanks,

greg k-h

Re: [PATCH] staging: fbtft: fix a typo

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-03-26 09:35:05

On Fri, Mar 26, 2021 at 05:16:34PM +0800, carlis wrote:
On Fri, 26 Mar 2021 09:37:48 +0100
Greg KH [off-list ref] wrote:
quoted
On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote:
quoted
From: "Carlis" <redacted>

Change 'tft' to 'TFT'  
Why?  What is wrong with "tft"?
I think abbreviations should be capitalized.
Why?  What requires this?

thanks,

greg k-h

Re: [PATCH] staging: fbtft: fix a typo

From: carlis <hidden>
Date: 2021-03-26 09:58:21

On Fri, 26 Mar 2021 10:33:57 +0100
Greg KH [off-list ref] wrote:
On Fri, Mar 26, 2021 at 05:16:34PM +0800, carlis wrote:
quoted
On Fri, 26 Mar 2021 09:37:48 +0100
Greg KH [off-list ref] wrote:
  
quoted
On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote:  
quoted
From: "Carlis" <redacted>

Change 'tft' to 'TFT'    
Why?  What is wrong with "tft"?
  
I think abbreviations should be capitalized.  
Why?  What requires this?
Many people use capital letters for abbreviations in comments, which I
think is a good practice
thanks,

greg k-h
thanks,
Xuezhi Zhang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help