Re: [PATCH 1/2] fbdev: omapfb: avoid -Wempty-body warning
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-03-22 15:06:17
Also in:
dri-devel, linux-omap, lkml
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-03-22 15:06:17
Also in:
dri-devel, linux-omap, lkml
On Mon, Mar 22, 2021 at 11:54 AM Arnd Bergmann [off-list ref] wrote:
From: Arnd Bergmann <arnd@arndb.de>
Building with 'make W=1' shows a few harmless warnings:
drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_calc_addr':
drivers/video/fbdev/omap2/omapfb/omapfb-main.c:823:56: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
823 | var->xoffset, var->yoffset, offset);
| ^
drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c: In function 'omapfb_ioctl':
drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c:911:45: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
911 | DBG("ioctl failed: %d\n", r);
Avoid these by using no_printk(), which adds format string checking as
well.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds