drivers/video/fbdev:modify 0 to NULL

Started by ChunyouTang on Mar 18, 2021 · 5 messages from 2 authors · Last reply Mar 18, 2021

Subsystems (2)

Maintainers (2)

STALE2064d

open the first message on its own page

Message details and related content
From: tangchunyou <redacted>

modify 0 to NULL,info is a pointer,it should be

compared with NULL,not 0

Signed-off-by: tangchunyou <redacted>
---
 drivers/video/fbdev/offb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
index 4501e84..cd1042f 100644
--- a/drivers/video/fbdev/offb.c
+++ b/drivers/video/fbdev/offb.c
@@ -412,7 +412,7 @@ static void __init offb_init_fb(const char *name,
 
 	info = framebuffer_alloc(sizeof(u32) * 16, NULL);
 
-	if (info == 0) {
+	if (info == NULL) {
 		release_mem_region(res_start, res_size);
 		return;
 	}
-- 
1.9.1

Message details and related content

On 3/17/21 21:33, ChunyouTang wrote:
quoted hunk
From: tangchunyou <redacted>

modify 0 to NULL,info is a pointer,it should be

compared with NULL,not 0

Signed-off-by: tangchunyou <redacted>
---
 drivers/video/fbdev/offb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
index 4501e84..cd1042f 100644
--- a/drivers/video/fbdev/offb.c
+++ b/drivers/video/fbdev/offb.c
@@ -412,7 +412,7 @@ static void __init offb_init_fb(const char *name,
 
 	info = framebuffer_alloc(sizeof(u32) * 16, NULL);
 
-	if (info == 0) {
+	if (info == NULL) {
if (!info) is better.

--
Gustavo
 		release_mem_region(res_start, res_size);
 		return;
 	}
Message details and related content
HI,Gustavo

On Wed, 17 Mar 2021 20:41:15 -0500
"Gustavo A. R. Silva" [off-list ref] wrote:
On 3/17/21 21:33, ChunyouTang wrote:
quoted
From: tangchunyou <redacted>

modify 0 to NULL,info is a pointer,it should be

compared with NULL,not 0

Signed-off-by: tangchunyou <redacted>
---
 drivers/video/fbdev/offb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
index 4501e84..cd1042f 100644
--- a/drivers/video/fbdev/offb.c
+++ b/drivers/video/fbdev/offb.c
@@ -412,7 +412,7 @@ static void __init offb_init_fb(const char
*name, 
 	info = framebuffer_alloc(sizeof(u32) * 16, NULL);
 
-	if (info == 0) {
+	if (info == NULL) {  
if (!info) is better.

--
Gustavo
quoted
 		release_mem_region(res_start, res_size);
 		return;
 	}
  
I think "if (info == NULL)" is more intuitive,and there have many
compare likes "if (info == NULL)" in this file.

--
ChunyouTang
Message details and related content
Hi,Gustavo

On Wed, 17 Mar 2021 20:54:41 -0500
"Gustavo A. R. Silva" [off-list ref] wrote:
On 3/17/21 21:47, Chunyou Tang wrote:
quoted
I think "if (info == NULL)" is more intuitive,and there have many
compare likes "if (info == NULL)" in this file.  
In that case, all those instances should be changed to if (!foo),
instead.

--
Gustavo
OK,I change it.

--
ChunyouTang
Message details and related content

On 3/17/21 21:47, Chunyou Tang wrote:
I think "if (info == NULL)" is more intuitive,and there have many
compare likes "if (info == NULL)" in this file.
In that case, all those instances should be changed to if (!foo), instead.

--
Gustavo
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help