Thread (4 messages) 4 messages, 4 authors, 2021-03-17

Re: [PATCH] backlight: qcom-wled: Use sink_addr for sync toggle

From: Lee Jones <hidden>
Date: 2021-03-17 09:16:39
Also in: dri-devel, linux-arm-msm, lkml, phone-devel

On Sun, 14 Mar 2021, Marijn Suijten wrote:
From: Obeida Shamoun <redacted>

WLED3_SINK_REG_SYNC is, as the name implies, a sink register offset.
Therefore, use the sink address as base instead of the ctrl address.

This fixes the sync toggle on wled4, which can be observed by the fact
that adjusting brightness now works.

It has no effect on wled3 because sink and ctrl base addresses are the
same.  This allows adjusting the brightness without having to disable
then reenable the module.

Signed-off-by: Obeida Shamoun <redacted>
Signed-off-by: Konrad Dybcio <redacted>
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
---
 drivers/video/backlight/qcom-wled.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help