[PATCH 1/2] dt-bindings: leds: backlight: qcom-wled: Add PMI8994 compatible
Subsystems:
arm/qualcomm mailing list , led subsystem , open firmware and flattened device tree bindings , the rest
1916d
13 messages,
5 authors,
2021-05-27 · open the first message on its own page
Document the newly added PMI8994 compatible.
Signed-off-by: Konrad Dybcio <redacted>
---
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
index 47938e372987..d839e75d9788 100644
--- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
+++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml @@ -19,6 +19,7 @@ properties:
compatible :
enum :
- qcom,pm8941-wled
+ - qcom,pmi8994-wled - qcom,pmi8998-wled
- qcom,pm660l-wled
- qcom,pm8150l-wled --
2.30.1
Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP.
Signed-off-by: Konrad Dybcio <redacted>
---
drivers/video/backlight/qcom-wled.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
index 3bc7800eb0a9..497b9035a908 100644
--- a/drivers/video/backlight/qcom-wled.c
+++ b/drivers/video/backlight/qcom-wled.c @@ -1704,6 +1704,7 @@ static int wled_remove(struct platform_device *pdev)
static const struct of_device_id wled_match_table [] = {
{ . compatible = "qcom,pm8941-wled" , . data = ( void * ) 3 },
+ { . compatible = "qcom,pmi8994-wled" , . data = ( void * ) 4 }, { . compatible = "qcom,pmi8998-wled" , . data = ( void * ) 4 },
{ . compatible = "qcom,pm660l-wled" , . data = ( void * ) 4 },
{ . compatible = "qcom,pm8150l-wled" , . data = ( void * ) 5 }, --
2.30.1
On Sun, 28 Feb 2021 13:41:04 +0100, Konrad Dybcio wrote: Document the newly added PMI8994 compatible.
Signed-off-by: Konrad Dybcio <redacted>
---
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml | 1 +
1 file changed, 1 insertion(+)
Acked-by: Rob Herring <robh@kernel.org>
On Sun, 28 Feb 2021, Konrad Dybcio wrote:
Document the newly added PMI8994 compatible.
Signed-off-by: Konrad Dybcio <redacted>
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On Sun, Feb 28, 2021 at 01:41:04PM +0100, Konrad Dybcio wrote: Document the newly added PMI8994 compatible.
Signed-off-by: Konrad Dybcio <redacted>
(For Lee) Acked-by: Daniel Thompson [off-list ref]
Daniel.
quoted hunk ---
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
index 47938e372987..d839e75d9788 100644
--- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
+++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml @@ -19,6 +19,7 @@ properties:
compatible :
enum :
- qcom,pm8941-wled
+ - qcom,pmi8994-wled - qcom,pmi8998-wled
- qcom,pm660l-wled
- qcom,pm8150l-wled --
2.30.1
On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP.
Signed-off-by: Konrad Dybcio <redacted>
Reviewed-by: Daniel Thompson <redacted>
Daniel.
quoted hunk ---
drivers/video/backlight/qcom-wled.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
index 3bc7800eb0a9..497b9035a908 100644
--- a/drivers/video/backlight/qcom-wled.c
+++ b/drivers/video/backlight/qcom-wled.c @@ -1704,6 +1704,7 @@ static int wled_remove(struct platform_device *pdev)
static const struct of_device_id wled_match_table [] = {
{ . compatible = "qcom,pm8941-wled" , . data = ( void * ) 3 },
+ { . compatible = "qcom,pmi8994-wled" , . data = ( void * ) 4 }, { . compatible = "qcom,pmi8998-wled" , . data = ( void * ) 4 },
{ . compatible = "qcom,pm660l-wled" , . data = ( void * ) 4 },
{ . compatible = "qcom,pm8150l-wled" , . data = ( void * ) 5 }, --
2.30.1
On Mon, 22 Mar 2021, Daniel Thompson wrote:
On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: quoted Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP.
Signed-off-by: Konrad Dybcio <redacted>
Reviewed-by: Daniel Thompson <redacted>
Why are you Reviewing/Acking a patch that was applied on the 10th?
quoted ---
drivers/video/backlight/qcom-wled.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
index 3bc7800eb0a9..497b9035a908 100644
--- a/drivers/video/backlight/qcom-wled.c
+++ b/drivers/video/backlight/qcom-wled.c @@ -1704,6 +1704,7 @@ static int wled_remove(struct platform_device *pdev)
static const struct of_device_id wled_match_table [] = {
{ . compatible = "qcom,pm8941-wled" , . data = ( void * ) 3 },
+ { . compatible = "qcom,pmi8994-wled" , . data = ( void * ) 4 }, { . compatible = "qcom,pmi8998-wled" , . data = ( void * ) 4 },
{ . compatible = "qcom,pm660l-wled" , . data = ( void * ) 4 },
{ . compatible = "qcom,pm8150l-wled" , . data = ( void * ) 5 },
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On Tue, Mar 23, 2021 at 08:39:35AM +0000, Lee Jones wrote: On Mon, 22 Mar 2021, Daniel Thompson wrote:
quoted On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: quoted Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP.
Signed-off-by: Konrad Dybcio <redacted>
Reviewed-by: Daniel Thompson <redacted>
Why are you Reviewing/Acking a patch that was applied on the 10th?
Simply an oversight. Looks like I forgot to remove it from my backlog
when it was applied.
Daniel.
quoted quoted ---
drivers/video/backlight/qcom-wled.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
index 3bc7800eb0a9..497b9035a908 100644
--- a/drivers/video/backlight/qcom-wled.c
+++ b/drivers/video/backlight/qcom-wled.c @@ -1704,6 +1704,7 @@ static int wled_remove(struct platform_device *pdev)
static const struct of_device_id wled_match_table [] = {
{ . compatible = "qcom,pm8941-wled" , . data = ( void * ) 3 },
+ { . compatible = "qcom,pmi8994-wled" , . data = ( void * ) 4 }, { . compatible = "qcom,pmi8998-wled" , . data = ( void * ) 4 },
{ . compatible = "qcom,pm660l-wled" , . data = ( void * ) 4 },
{ . compatible = "qcom,pm8150l-wled" , . data = ( void * ) 5 },
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On Tue, 23 Mar 2021, Daniel Thompson wrote:
On Tue, Mar 23, 2021 at 08:39:35AM +0000, Lee Jones wrote: quoted On Mon, 22 Mar 2021, Daniel Thompson wrote:
quoted On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: quoted Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP.
Signed-off-by: Konrad Dybcio <redacted>
Reviewed-by: Daniel Thompson <redacted>
Why are you Reviewing/Acking a patch that was applied on the 10th?
Simply an oversight. Looks like I forgot to remove it from my backlog
when it was applied.
I wondered if I'd made a mistake.
No problem. Thanks for the clarification.
quoted quoted quoted ---
drivers/video/backlight/qcom-wled.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
index 3bc7800eb0a9..497b9035a908 100644
--- a/drivers/video/backlight/qcom-wled.c
+++ b/drivers/video/backlight/qcom-wled.c @@ -1704,6 +1704,7 @@ static int wled_remove(struct platform_device *pdev)
static const struct of_device_id wled_match_table [] = {
{ . compatible = "qcom,pm8941-wled" , . data = ( void * ) 3 },
+ { . compatible = "qcom,pmi8994-wled" , . data = ( void * ) 4 }, { . compatible = "qcom,pmi8998-wled" , . data = ( void * ) 4 },
{ . compatible = "qcom,pm660l-wled" , . data = ( void * ) 4 },
{ . compatible = "qcom,pm8150l-wled" , . data = ( void * ) 5 },
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Hi Lee,
On Tue, Mar 23, 2021 at 9:40 AM Lee Jones [off-list ref] wrote: On Mon, 22 Mar 2021, Daniel Thompson wrote: quoted On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: quoted Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP.
Signed-off-by: Konrad Dybcio <redacted>
Reviewed-by: Daniel Thompson <redacted>
Why are you Reviewing/Acking a patch that was applied on the 10th?
Only 12 days later?!?
It's not uncommon to receive acks for patches after they have been
applied upstream. But it is if the patch was applied 10 years and 9
months ago!
https://lore.kernel.org/linux-m68k/F5513AE92A5A1047AC2F91AEBB9202680288CBBA3983@E2K7-MS2.ds.strath.ac.uk/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Wed, 24 Mar 2021, Geert Uytterhoeven wrote:
Hi Lee,
On Tue, Mar 23, 2021 at 9:40 AM Lee Jones [off-list ref] wrote: quoted On Mon, 22 Mar 2021, Daniel Thompson wrote: quoted On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: quoted Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP.
Signed-off-by: Konrad Dybcio <redacted>
Reviewed-by: Daniel Thompson <redacted>
Why are you Reviewing/Acking a patch that was applied on the 10th?
Only 12 days later?!?
It's not uncommon to receive acks for patches after they have been
applied upstream. But it is if the patch was applied 10 years and 9
months ago!
https://lore.kernel.org/linux-m68k/F5513AE92A5A1047AC2F91AEBB9202680288CBBA3983@E2K7-MS2.ds.strath.ac.uk/
That truly is next level! :)
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Hi,
Why are you Reviewing/Acking a patch that was applied on the 10th?
Forgive me if it turns out I'm blind, but I can't see the patch being in either -next, backlight/for-next, or 5.13-rc3. Perhaps it was omitted after all?
Konrad
On Thu, 27 May 2021, Konrad Dybcio wrote:
Hi,
quoted Why are you Reviewing/Acking a patch that was applied on the 10th?
Forgive me if it turns out I'm blind, but I can't see the patch
being in either -next, backlight/for-next, or 5.13-rc3. Perhaps it
was omitted after all?
Interesting. It's not you, it's me!
No idea what happened exactly TBH, but it's applied again.
Should be in -next tomorrow. Apologies for the delay.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog