On 2/16/21 9:48 AM, Kumar Kartikeya Dwivedi wrote:

On Tue, Feb 16, 2021 at 08:24:59PM IST, Alex Elder wrote:

quoted

This is a good change.  But while you're at it, I would
appreciate if you would convert a few spots to use
sizeof(dest) rather than a fixed constant.  I will
point them out below.

If this is the *only* request for a change on your
series, please tell me that and I can sign off on

So far, this has been the only request.

quoted

this without you implementing my suggestion.  But
if you post a version 2, please do what I describe.

I will incorporate these if I end up sending a v2.

Alternatively, would a separate patch with your suggestions applied on top of
this be acceptable, if I don't?

Yes.  Assuming you do that, for this patch (as-is):

Reviewed-by: Alex Elder <redacted>