Re: [PATCH] video: use getter/setter functions
From: Lee Jones <hidden>
Date: 2021-02-10 08:25:36
Also in:
dri-devel, kernel-janitors, linux-arm-kernel, linux-arm-msm, linux-omap, lkml
On Tue, 09 Feb 2021, Julia Lawall wrote:
Use getter and setter functions, for platform_device structures and a spi_device structure. Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> --- drivers/video/backlight/qcom-wled.c | 2 +-
This patch is fine. Could you please split it out and submit it separately though please.
drivers/video/fbdev/amifb.c | 4 ++-- drivers/video/fbdev/da8xx-fb.c | 4 ++-- drivers/video/fbdev/imxfb.c | 2 +- drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c | 6 +++--- drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 4 ++-- drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++-- drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 2 +- drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 2 +- drivers/video/fbdev/xilinxfb.c | 2 +- 10 files changed, 16 insertions(+), 16 deletions(-)
...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index 3bc7800eb0a9..091f07e7c145 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c@@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device *pdev) static int wled_remove(struct platform_device *pdev) { - struct wled *wled = dev_get_drvdata(&pdev->dev); + struct wled *wled = platform_get_drvdata(pdev); mutex_destroy(&wled->lock); cancel_delayed_work_sync(&wled->ovp_work);
For my own reference (apply this as-is to your sign-off block): Acked-for-Backlight-by: Lee Jones [off-list ref] -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog