Re: [PATCH v10] staging: fbtft: add tearing signal detect
From: Joe Perches <joe@perches.com>
Date: 2021-01-27 18:22:39
Also in:
dri-devel, lkml
Subsystem:
checkpatch, the rest · Maintainers:
Andy Whitcroft, Joe Perches, Linus Torvalds
Comments are the exception to the "no spaces at the start of a line" rule. I was expecting that the kbuild-bot would send a Smatch warning for inconsistent indenting, but comments are not counted there either. I'm sort of surprised that we don't have checkpatch rule about the missing space characters. It should be: "/* Tearing Effect Line On */".
Maybe this but the "preceded by a tab" test is pretty noisy. ---
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4f8494527139..72347e82d384 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl@@ -3720,6 +3720,22 @@ sub process { s/(\(\s*$Type\s*\))[ \t]+/$1/; } } + +# Comment styles +# Initial comment only lines that have a leading space + if ($rawline =~ m{^\+([ \t]+)(?:/\*|//)} && $1 =~ / /) { + WARN("COMMENT_STYLE", + "Initial comment lines should be indented only with tabs\n" . $herecurr); +# comments not aligned on tabs + } elsif ($rawline !~ m{^\+(?:/\*|//)} && + $rawline =~ m{^\+.*[^\t](?:/\*|//)}) { + CHK("COMMENT_STYLE", + "Comments should generally be preceded by a tab\n" . $herecurr); + } + +# comment initiators should generally be followed by a space if using words + if ($rawline =~ m{^\+.*(?:/\*|//)\w}) { + WARN("COMMENT_STYLE", + "Comment text should use a space after the comment initiator\n" . $herecurr); + } # Block comment styles # Networking with an initial /*