Re: [PATCH v9] staging: fbtft: add tearing signal detect

On Wed, 27 Jan 2021 14:11:31 +0100
Greg KH [off-list ref] wrote:

On Wed, Jan 27, 2021 at 08:57:37PM +0800, Carlis wrote:

quoted

From: zhangxuezhi <redacted>

For st7789v ic,add tearing signal detect to avoid screen tearing  

I need a much better changelog description here please.

quoted

Signed-off-by: zhangxuezhi <redacted>
---
v9: change pr_* to dev_*
---  

What changed in all of your previous versions?  All of them should be
listed here, right?

quoted

 drivers/staging/fbtft/fb_st7789v.c | 132
++++++++++++++++++++++++++++++++++++- drivers/staging/fbtft/fbtft.h
     |   1 + 2 files changed, 132 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_st7789v.c

b/drivers/staging/fbtft/fb_st7789v.c index 3a280cc..9aa2f36 100644

--- a/drivers/staging/fbtft/fb_st7789v.c
+++ b/drivers/staging/fbtft/fb_st7789v.c

@@ -9,9 +9,12 @@
 #include <linux/delay.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
+#include <linux/mutex.h>
+#include <linux/interrupt.h>
+#include <linux/completion.h>
 #include <linux/module.h>
 #include <video/mipi_display.h>
-
+#include <linux/gpio/consumer.h>
 #include "fbtft.h"
 
 #define DRVNAME "fb_st7789v"

@@ -66,6 +69,32 @@ enum st7789v_command {
 #define MADCTL_MX BIT(6) /* bitmask for column address order */
 #define MADCTL_MY BIT(7) /* bitmask for page address order */
 
+#define SPI_PANEL_TE_TIMEOUT	400  

What is the units here?  Where did this value come from?

hi,the units is msecs,and i got this value from a qcom mdp spi
drivers,and i will add the notes you need in the patch v10

quoted

+static struct mutex te_mutex;/*mutex for tearing line*/  

Does that look correct???

thanks,

greg k-h