Re: [PATCH 3/6 v6] fbdev/simplefb: Add the N64's mode

On Fri, 15 Jan 2021 14:01:36 +0100
Hans de Goede [off-list ref] wrote:

I am honestly not entirely convinced of the #ifdef-ery this adds. I understand that RAM is
tight on the N64, but this saves just 700 bytes, which even on the N64 is not a lot.

Right now it might be just 1 #ifdef for the N64, but if other platforms follow this example?

Honestly I would prefer to just see the format added to the existing SIMPLEFB_FORMATS
define without the #ifdef.

Alternatively:

Are you using devicetree or are you using a board.c file to instantiate everything?
If it is the latter I guess we could add a const struct simplefb_format * to the pdata
and then just pass in the format directly. I can even imagine the code which uses
the SIMPLEFB_FORMATS having a #ifdef CONFIG_OF around it in that case to optimize it out...

That would be a more generic solution which hopefully will save as much if not more
space...

No devicetree, and CONFIG_OF is disabled too. All init done in the
board .c. Not looking to get too involved with simplefb though, so I'll
be sending a patch that just adds the format.

- Lauri