Thread (36 messages) 36 messages, 4 authors, 2020-12-08

Re: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU

From: Sam Ravnborg <hidden>
Date: 2020-12-06 21:49:43
Also in: dri-devel, oe-kbuild-all

Hi "kernel test robot"
On Sun, Dec 06, 2020 at 10:48:14PM +0100, Sam Ravnborg wrote:
commit aa1f4345b5480502a4e61addf5c59d606fdbce8f
Author: Sam Ravnborg [off-list ref]
Date:   Mon Nov 30 22:09:29 2020 +0100

    sh: Fix set but not used warnings with !CONFIG_MMU
    
    Building fbdev drivers for sh with W=1 produces the following warning:
    
        tmiofb.c: In function ‘tmiofb_remove’:
        tmiofb.c:805:21: warning: variable ‘par’ set but not used
    
    This is with allmodconfig and ARCH=sh
    
    This boiled down to iounmap() defined as empty for !CONFIG_MMU.
    Fix this by by adding "(void)addr;" to tell the compiler the
    argument to iounmap() should be considered used.
    
    v4:
      - Fix build error of ethernet driver (kernel test robot)
        Added missing () around macro parameter
Thanks for thee quick report - it was easy to reproduce.
I hope this is enough for the robot to pick up the updated patch.

	Sam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help