Re: [PATCH v2 15/28] video: fbdev: neofb: Fix set but not used warning for CursorMem

From
Thomas Zimmermann <tzimmermann@suse.de>
Date
2020-11-30 12:16:53
Also in
dri-devel
Reply to
Sam Ravnborg, 2020-11-28

Am 28.11.20 um 23:41 schrieb Sam Ravnborg:
Fix W=1 warnings by removing unused code

v2:
   - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Sam Ravnborg <redacted>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Evgeny Novikov <redacted>
Cc: Jani Nikula <redacted>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Lee Jones <redacted>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
quoted hunk ↗ jump to hunk
---
  drivers/video/fbdev/neofb.c | 4 ----
  1 file changed, 4 deletions(-)
diff --git a/drivers/video/fbdev/neofb.c b/drivers/video/fbdev/neofb.c
index 09a20d4ab35f..c0f4f402da3f 100644
--- a/drivers/video/fbdev/neofb.c
+++ b/drivers/video/fbdev/neofb.c
@@ -1843,7 +1843,6 @@ static int neo_init_hw(struct fb_info *info)
  	struct neofb_par *par = info->par;
  	int videoRam = 896;
  	int maxClock = 65000;
-	int CursorMem = 1024;
  	int CursorOff = 0x100;
  
  	DBG("neo_init_hw");
@@ -1895,19 +1894,16 @@ static int neo_init_hw(struct fb_info *info)
  	case FB_ACCEL_NEOMAGIC_NM2070:
  	case FB_ACCEL_NEOMAGIC_NM2090:
  	case FB_ACCEL_NEOMAGIC_NM2093:
-		CursorMem = 2048;
  		CursorOff = 0x100;
  		break;
  	case FB_ACCEL_NEOMAGIC_NM2097:
  	case FB_ACCEL_NEOMAGIC_NM2160:
-		CursorMem = 1024;
  		CursorOff = 0x100;
  		break;
  	case FB_ACCEL_NEOMAGIC_NM2200:
  	case FB_ACCEL_NEOMAGIC_NM2230:
  	case FB_ACCEL_NEOMAGIC_NM2360:
  	case FB_ACCEL_NEOMAGIC_NM2380:
-		CursorMem = 1024;
  		CursorOff = 0x1000;
  
  		par->neo2200 = (Neo2200 __iomem *) par->mmio_vbase;
-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Attachments

Thread (78 messages) 78 messages, 7 authors, last reply 2020-12-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help