Re: [PATCH v2 12/28] video: fbdev: tdfx: Fix set but not used warning in att_outb()

From
Thomas Zimmermann <tzimmermann@suse.de>
Date
2020-11-30 12:12:25
Also in
dri-devel
Reply to
Sam Ravnborg, 2020-11-28

Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
The tmp variable were assigned but the result was never used,
s/were/was
so delete the tmp variable.

v2:
   - Update subject (Lee)

Signed-off-by: Sam Ravnborg <redacted>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Sam Ravnborg <redacted>
Cc: Jani Nikula <redacted>
Cc: Daniel Vetter <redacted>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Lee Jones <redacted>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
quoted hunk ↗ jump to hunk
---
  drivers/video/fbdev/tdfxfb.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c
index f056d80f6359..67e37a62b07c 100644
--- a/drivers/video/fbdev/tdfxfb.c
+++ b/drivers/video/fbdev/tdfxfb.c
@@ -206,9 +206,7 @@ static inline u8 crt_inb(struct tdfx_par *par, u32 idx)
  
  static inline void att_outb(struct tdfx_par *par, u32 idx, u8 val)
  {
-	unsigned char tmp;
-
-	tmp = vga_inb(par, IS1_R);
+	vga_inb(par, IS1_R);
It resets the attribute register's state. Hopefully, this doesn't get optimized away.
  	vga_outb(par, ATT_IW, idx);
  	vga_outb(par, ATT_IW, val);
  }
-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Attachments

Thread (78 messages) 78 messages, 7 authors, last reply 2020-12-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help