Re: [PATCH v2 01/28] video: Fix kernel-doc warnings in of_display_timing + of_videomode

From
Sam Ravnborg <hidden>
Date
2020-11-29 11:22:13
Also in
dri-devel
Reply to
Thomas Zimmermann, 2020-11-29
On Sun, Nov 29, 2020 at 11:01:13AM +0100, Thomas Zimmermann wrote:

Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
quoted
Fix kernel-doc warnings reported when using W=1.

v2:
   - Improve subject (Lee)

Signed-off-by: Sam Ravnborg <redacted>
Cc: Lee Jones <redacted>
Cc: <redacted>
---
  drivers/video/of_display_timing.c | 1 +
  drivers/video/of_videomode.c      | 8 ++++----
  2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c
index abc9ada798ee..f93b6abbe258 100644
--- a/drivers/video/of_display_timing.c
+++ b/drivers/video/of_display_timing.c
@@ -52,6 +52,7 @@ static int parse_timing_property(const struct device_node *np, const char *name,
  /**
   * of_parse_display_timing - parse display_timing entry from device_node
   * @np: device_node with the properties
+ * @dt: display_timing that contains the result. I may be partially written in case of errors
   **/
  static int of_parse_display_timing(const struct device_node *np,
  		struct display_timing *dt)
diff --git a/drivers/video/of_videomode.c b/drivers/video/of_videomode.c
index 67aff2421c29..a5bb02f02b44 100644
--- a/drivers/video/of_videomode.c
+++ b/drivers/video/of_videomode.c
@@ -13,10 +13,10 @@
  #include <video/videomode.h>
  /**
- * of_get_videomode - get the videomode #<index> from devicetree
What's wrong with this line? We use the dash in lots of places?
I think my OCD kicked in and I made all lines use ':'.
I will re-add the dash when I apply.
Besides this,

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
	Thanks
Thread (78 messages) 78 messages, 7 authors, last reply 2020-12-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help