Re: [PATCH 000/141] Fix fall-through warnings for Clang
From: Edward Cree <ecree.xilinx@gmail.com>
Date: 2020-11-25 23:03:03
Also in:
amd-gfx, bridge, ceph-devel, dm-devel, dri-devel, intel-gfx, intel-wired-lan, keyrings, linux-acpi, linux-arm-msm, linux-block, linux-can, linux-cifs, linux-crypto, linux-ext4, linux-gpio, linux-hardening, linux-hwmon, linux-i3c, linux-ide, linux-iio, linux-input, linux-integrity, linux-media, linux-mediatek, linux-mm, linux-mmc, linux-nfs, linux-rdma, linux-renesas-soc, linux-scsi, linux-sctp, linux-security-module, linux-usb, linux-watchdog, linux-wireless, lkml, netdev, netfilter-devel, op-tee, selinux, target-devel, xen-devel
On 24/11/2020 21:25, Kees Cook wrote:
I still think this isn't right -- it's a case statement that runs off the end without an explicit flow control determination.
Proves too much — for instance
case foo:
case bar:
thing;
break;
doesn't require a fallthrough; after case foo:, and afaik
no-one is suggesting it should. Yet it, too, is "a case
statement that runs off the end without an explicit flow
control determination".
-ed