Re: [PATCH] fbcon: Remove the superfluous break
From: Gustavo A. R. Silva <hidden>
Date: 2020-09-17 19:15:23
Also in:
dri-devel, lkml
On 9/17/20 08:15, Jing Xiangfeng wrote:
Remove the superfuous break, as there is a 'return' before it. Signed-off-by: Jing Xiangfeng <redacted>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Also, the following Fixes tag should be included in the changelog text:
Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling")
Thanks
--
Gustavo
quoted hunk ↗ jump to hunk
--- drivers/video/fbdev/core/fbcon.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 0b49b0f44edf..623359aadd1e 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c@@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, vc->vc_video_erase_char, vc->vc_size_row * count); return true; - break; case SCROLL_WRAP_MOVE: if (b - t - count > 3 * vc->vc_rows >> 2) {@@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, vc->vc_video_erase_char, vc->vc_size_row * count); return true; - break; case SCROLL_WRAP_MOVE: if (b - t - count > 3 * vc->vc_rows >> 2) {