Re: [PATCH] [video/fbdev] mbxfb_remove: fix null pointer dereference
From: Andy Shevchenko <hidden>
Date: 2020-07-26 08:57:19
Also in:
dri-devel, lkml
On Sun, Jul 26, 2020 at 8:26 AM Gaurav Singh [off-list ref] wrote:
Function mbxfb_debugfs_remove() accesses fbi->par without NULL check, hence do the NULL check in the caller mbxfb_remove().
...
quoted hunk ↗ jump to hunk
@@ -1012,11 +1012,10 @@ static int mbxfb_remove(struct platform_device *dev) write_reg_dly(SYSRST_RST, SYSRST); - mbxfb_debugfs_remove(fbi); -
if (fbi) {Can you explain how this is NULL on ->remove()? I bet this check is simply redundant. But you have to check and update commit message accordingly.
quoted hunk ↗ jump to hunk
struct mbxfb_info *mfbi = fbi->par; + mbxfb_debugfs_remove(fbi); unregister_framebuffer(fbi); if (mfbi) { if (mfbi->platform_remove)
-- With Best Regards, Andy Shevchenko