Re: [PATCH] fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins.
flat view
From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Date: 2020-07-14 13:37:31
Also in:
dri-devel, lkml
Possibly related (same subject, not in this thread)
- 2020-07-15 · Re: [PATCH] fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins. · Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
On 2020/07/14 19:27, Tetsuo Handa wrote:
On 2020/07/14 16:22, Bartlomiej Zolnierkiewicz wrote:quoted
How does this patch relate to: https://marc.info/?l=linux-fbdev&m9415024816722&w=2 ? It seems to address the same issue, I've added George and Dan to Cc:.George Kennedy's patch does not help for my case.
OK. You can add Reported-and-tested-by: syzbot <redacted> to my patch. By the way, if /* bitfill_aligned() assumes that it's at least 8x8 */ is true, don't we need to also check that the rect to fill is at least 8x8 in bit_clear_margins() ? (Well, I feel did it mean multiple of 8x8 ? Then, what is bitfill_unaligned() for ?)