From: Lee Jones <hidden> Date: 2020-06-24 15:04:53
This has been missing since the conversion to 'struct device' in 2007.
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Jamey Hicks <redacted>
Cc: Andrew Zabolotny <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/video/backlight/lcd.c | 1 +
1 file changed, 1 insertion(+)
From: Lee Jones <hidden> Date: 2020-06-24 15:04:58
unsigned ints 'sources' and 'bank' cannot be less than LM3630A_SINK_0 (0)
and LM3630A_BANK_0 (0) respecitively, so change the logic to only check
for thier two possible valid values.
Fixes W=1 warnings:
drivers/video/backlight/lm3630a_bl.c: In function ‘lm3630a_parse_led_sources’:
drivers/video/backlight/lm3630a_bl.c:394:18: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
394 | if (sources[i] < LM3630A_SINK_0 || sources[i] > LM3630A_SINK_1)
| ^
drivers/video/backlight/lm3630a_bl.c: In function ‘lm3630a_parse_bank’:
drivers/video/backlight/lm3630a_bl.c:415:11: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
415 | if (bank < LM3630A_BANK_0 || bank > LM3630A_BANK_1)
| ^
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Daniel Jeong <redacted>
Cc: LDD MLP <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/video/backlight/lm3630a_bl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Lee Jones <hidden> Date: 2020-06-24 15:05:07
Kerneldoc syntax is used, but not complete. Descriptions required.
Prevents warnings like:
drivers/video/backlight/backlight.c:329: warning: Function parameter or member 'reason' not described in 'backlight_force_update'
drivers/video/backlight/backlight.c:354: warning: Function parameter or member 'props' not described in 'backlight_device_register'
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Jamey Hicks <redacted>
Cc: Andrew Zabolotny <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/video/backlight/backlight.c | 2 ++
1 file changed, 2 insertions(+)
From: Lee Jones <hidden> Date: 2020-06-24 15:05:10
Kerneldoc syntax is used, but not complete. Descriptions required.
Prevents warnings like:
drivers/video/backlight/ili922x.c:298: warning: Function parameter or member 'spi' not described in 'ili922x_reg_dump'
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Software Engineering <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/video/backlight/ili922x.c | 2 ++
1 file changed, 2 insertions(+)
From: Lee Jones <hidden> Date: 2020-06-24 15:05:15
W=1 kernel build reports:
drivers/video/backlight/lms501kf03.c:96:28: warning: ‘seq_sleep_in’ defined but not used [-Wunused-const-variable=]
96 | static const unsigned char seq_sleep_in[] = {
| ^~~~~~~~~~~~
drivers/video/backlight/lms501kf03.c:92:28: warning: ‘seq_up_dn’ defined but not used [-Wunused-const-variable=]
92 | static const unsigned char seq_up_dn[] = {
| ^~~~~~~~~
Either 'seq_sleep_in' nor 'seq_up_dn' have been used since the
driver first landed in 2013.
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/video/backlight/lms501kf03.c | 8 --------
1 file changed, 8 deletions(-)
From: Lee Jones <hidden> Date: 2020-06-24 15:05:24
Kerneldoc syntax is used, but not complete. Descriptions required.
Prevents warnings like:
drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 's' not described in 'CHECK_FREQ_REG'
drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 'x' not described in 'CHECK_FREQ_REG'
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Software Engineering <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/video/backlight/ili922x.c | 2 ++
1 file changed, 2 insertions(+)
From: Sam Ravnborg <hidden> Date: 2020-06-24 15:32:23
Hi Lee.
On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote:
Attempting to clean-up W=1 kernel builds, which are currently
overwhelmingly riddled with niggly little warnings.
Lee Jones (8):
backlight: lms501kf03: Remove unused const variables
backlight: lcd: Add missing kerneldoc entry for 'struct device parent'
backlight: ili922x: Add missing kerneldoc descriptions for
CHECK_FREQ_REG() args
backlight: ili922x: Remove invalid use of kerneldoc syntax
backlight: ili922x: Add missing kerneldoc description for
ili922x_reg_dump()'s arg
I wonder why these warnings show up as nothing pulls in this .c file.
Anyway I would suggest to drop using kerneldoc syntax for single drivers
like this - and the benefit here is low.
Now they are typed, otherwise this ahd been fine in a single patch.
backlight: backlight: Supply description for function args in existing
Kerneldocs
backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0
backlight: qcom-wled: Remove unused configs for LED3 and LED4
The other fixes looks good.
They are all:
Acked-by: Sam Ravnborg <redacted>
Sam
From: Lee Jones <hidden> Date: 2020-06-24 15:43:27
On Wed, 24 Jun 2020, Sam Ravnborg wrote:
Hi Lee.
On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote:
quoted
Attempting to clean-up W=1 kernel builds, which are currently
overwhelmingly riddled with niggly little warnings.
Lee Jones (8):
backlight: lms501kf03: Remove unused const variables
backlight: lcd: Add missing kerneldoc entry for 'struct device parent'
quoted
backlight: ili922x: Add missing kerneldoc descriptions for
CHECK_FREQ_REG() args
backlight: ili922x: Remove invalid use of kerneldoc syntax
backlight: ili922x: Add missing kerneldoc description for
ili922x_reg_dump()'s arg
I wonder why these warnings show up as nothing pulls in this .c file.
Anyway I would suggest to drop using kerneldoc syntax for single drivers
like this - and the benefit here is low.
Now they are typed, otherwise this ahd been fine in a single patch.
What do you mean by 'nothing pulls it in'?
quoted
backlight: backlight: Supply description for function args in existing
Kerneldocs
backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0
backlight: qcom-wled: Remove unused configs for LED3 and LED4
The other fixes looks good.
They are all:
Acked-by: Sam Ravnborg <redacted>
From: Sam Ravnborg <hidden> Date: 2020-06-24 16:24:53
Hi Lee.
On Wed, Jun 24, 2020 at 04:43:21PM +0100, Lee Jones wrote:
On Wed, 24 Jun 2020, Sam Ravnborg wrote:
quoted
Hi Lee.
On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote:
quoted
Attempting to clean-up W=1 kernel builds, which are currently
overwhelmingly riddled with niggly little warnings.
Lee Jones (8):
backlight: lms501kf03: Remove unused const variables
backlight: lcd: Add missing kerneldoc entry for 'struct device parent'
quoted
backlight: ili922x: Add missing kerneldoc descriptions for
CHECK_FREQ_REG() args
backlight: ili922x: Remove invalid use of kerneldoc syntax
backlight: ili922x: Add missing kerneldoc description for
ili922x_reg_dump()'s arg
I wonder why these warnings show up as nothing pulls in this .c file.
Anyway I would suggest to drop using kerneldoc syntax for single drivers
like this - and the benefit here is low.
Now they are typed, otherwise this ahd been fine in a single patch.
What do you mean by 'nothing pulls it in'?
There are no .rst files that includes any:
.. kernel-doc:: drivers/video/backlight/ili922x.c
so I do not see how the kernel-doc comments will be used by any
of the generated kernel-docs.
Sam
quoted
quoted
backlight: backlight: Supply description for function args in existing
Kerneldocs
backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0
backlight: qcom-wled: Remove unused configs for LED3 and LED4
The other fixes looks good.
They are all:
Acked-by: Sam Ravnborg <redacted>
From: Lee Jones <hidden> Date: 2020-06-25 08:03:53
On Wed, 24 Jun 2020, Sam Ravnborg wrote:
Hi Lee.
On Wed, Jun 24, 2020 at 04:43:21PM +0100, Lee Jones wrote:
quoted
On Wed, 24 Jun 2020, Sam Ravnborg wrote:
quoted
Hi Lee.
On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote:
quoted
Attempting to clean-up W=1 kernel builds, which are currently
overwhelmingly riddled with niggly little warnings.
Lee Jones (8):
backlight: lms501kf03: Remove unused const variables
backlight: lcd: Add missing kerneldoc entry for 'struct device parent'
quoted
backlight: ili922x: Add missing kerneldoc descriptions for
CHECK_FREQ_REG() args
backlight: ili922x: Remove invalid use of kerneldoc syntax
backlight: ili922x: Add missing kerneldoc description for
ili922x_reg_dump()'s arg
I wonder why these warnings show up as nothing pulls in this .c file.
Anyway I would suggest to drop using kerneldoc syntax for single drivers
like this - and the benefit here is low.
Now they are typed, otherwise this ahd been fine in a single patch.
What do you mean by 'nothing pulls it in'?
There are no .rst files that includes any:
.. kernel-doc:: drivers/video/backlight/ili922x.c
so I do not see how the kernel-doc comments will be used by any
of the generated kernel-docs.
Looks like a common problem (if it is actually a problem):
$ ./scripts/find-unused-docs.sh . | wc -l
1476
The role of this patch-set is not to eradicate unused kerneldoc
headers, but to ensure they are formatted correctly. W=1 builds
currently complain of ill formatted kerneldocs, which is currently
littering the build-log and masking some more important issues (which
I'm also trying to fix en route).
quoted
quoted
quoted
backlight: backlight: Supply description for function args in existing
Kerneldocs
backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0
backlight: qcom-wled: Remove unused configs for LED3 and LED4
The other fixes looks good.
They are all:
Acked-by: Sam Ravnborg <redacted>
From: Daniel Thompson <hidden> Date: 2020-06-25 09:24:41
On Wed, Jun 24, 2020 at 03:57:14PM +0100, Lee Jones wrote:
W=1 kernel build reports:
drivers/video/backlight/lms501kf03.c:96:28: warning: ‘seq_sleep_in’ defined but not used [-Wunused-const-variable=]
96 | static const unsigned char seq_sleep_in[] = {
| ^~~~~~~~~~~~
drivers/video/backlight/lms501kf03.c:92:28: warning: ‘seq_up_dn’ defined but not used [-Wunused-const-variable=]
92 | static const unsigned char seq_up_dn[] = {
| ^~~~~~~~~
Either 'seq_sleep_in' nor 'seq_up_dn' have been used since the
driver first landed in 2013.
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Signed-off-by: Lee Jones <redacted>
From: Daniel Thompson <hidden> Date: 2020-06-25 09:28:35
On Wed, Jun 24, 2020 at 03:57:15PM +0100, Lee Jones wrote:
This has been missing since the conversion to 'struct device' in 2007.
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Jamey Hicks <redacted>
Cc: Andrew Zabolotny <redacted>
Signed-off-by: Lee Jones <redacted>
From: Daniel Thompson <hidden> Date: 2020-06-25 09:40:59
On Wed, Jun 24, 2020 at 03:57:16PM +0100, Lee Jones wrote:
quoted hunk
Kerneldoc syntax is used, but not complete. Descriptions required.
Prevents warnings like:
drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 's' not described in 'CHECK_FREQ_REG'
drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 'x' not described in 'CHECK_FREQ_REG'
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Software Engineering <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/video/backlight/ili922x.c | 2 ++
1 file changed, 2 insertions(+)
What's wrong with "a pointer to an SPI device"?
I am aware, having looked it up to find out what the above actually
means, that this is how struct spi_device is described in its own kernel
doc but quoting at that level of detail of both overkill and confusing.
Daniel.
+ * @x: pointer to the read/write buffer pair
*/
#define CHECK_FREQ_REG(s, x) \
do { \
--
2.25.1
From: Daniel Thompson <hidden> Date: 2020-06-25 09:43:25
On Wed, Jun 24, 2020 at 03:57:18PM +0100, Lee Jones wrote:
quoted hunk
Kerneldoc syntax is used, but not complete. Descriptions required.
Prevents warnings like:
drivers/video/backlight/ili922x.c:298: warning: Function parameter or member 'spi' not described in 'ili922x_reg_dump'
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Software Engineering <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/video/backlight/ili922x.c | 2 ++
1 file changed, 2 insertions(+)
Similar to previous... and I also noticed that there are several other
existing @spi descriptions in this file and it would be good to make
them consistent.
Daniel.
From: Daniel Thompson <hidden> Date: 2020-06-25 09:43:51
On Wed, Jun 24, 2020 at 03:57:19PM +0100, Lee Jones wrote:
Kerneldoc syntax is used, but not complete. Descriptions required.
Prevents warnings like:
drivers/video/backlight/backlight.c:329: warning: Function parameter or member 'reason' not described in 'backlight_force_update'
drivers/video/backlight/backlight.c:354: warning: Function parameter or member 'props' not described in 'backlight_device_register'
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Jamey Hicks <redacted>
Cc: Andrew Zabolotny <redacted>
Signed-off-by: Lee Jones <redacted>
From: Daniel Thompson <hidden> Date: 2020-06-25 09:45:16
On Wed, Jun 24, 2020 at 03:57:20PM +0100, Lee Jones wrote:
unsigned ints 'sources' and 'bank' cannot be less than LM3630A_SINK_0 (0)
and LM3630A_BANK_0 (0) respecitively, so change the logic to only check
for thier two possible valid values.
Fixes W=1 warnings:
drivers/video/backlight/lm3630a_bl.c: In function ‘lm3630a_parse_led_sources’:
drivers/video/backlight/lm3630a_bl.c:394:18: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
394 | if (sources[i] < LM3630A_SINK_0 || sources[i] > LM3630A_SINK_1)
| ^
drivers/video/backlight/lm3630a_bl.c: In function ‘lm3630a_parse_bank’:
drivers/video/backlight/lm3630a_bl.c:415:11: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
415 | if (bank < LM3630A_BANK_0 || bank > LM3630A_BANK_1)
| ^
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Daniel Jeong <redacted>
Cc: LDD MLP <redacted>
Signed-off-by: Lee Jones <redacted>
From: Lee Jones <hidden> Date: 2020-06-25 10:33:41
On Thu, 25 Jun 2020, Daniel Thompson wrote:
On Wed, Jun 24, 2020 at 03:57:16PM +0100, Lee Jones wrote:
quoted
Kerneldoc syntax is used, but not complete. Descriptions required.
Prevents warnings like:
drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 's' not described in 'CHECK_FREQ_REG'
drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 'x' not described in 'CHECK_FREQ_REG'
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Software Engineering <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/video/backlight/ili922x.c | 2 ++
1 file changed, 2 insertions(+)
What's wrong with "a pointer to an SPI device"?
I am aware, having looked it up to find out what the above actually
means, that this is how struct spi_device is described in its own kernel
doc but quoting at that level of detail of both overkill and confusing.
I figured that using the official description would be better than
making something up. However if you think it's better to KISS, then I
can change it.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
From: Sam Ravnborg <hidden> Date: 2020-06-25 18:57:54
Hi Lee.
On Thu, Jun 25, 2020 at 09:03:37AM +0100, Lee Jones wrote:
On Wed, 24 Jun 2020, Sam Ravnborg wrote:
quoted
Hi Lee.
On Wed, Jun 24, 2020 at 04:43:21PM +0100, Lee Jones wrote:
quoted
On Wed, 24 Jun 2020, Sam Ravnborg wrote:
quoted
Hi Lee.
On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote:
quoted
Attempting to clean-up W=1 kernel builds, which are currently
overwhelmingly riddled with niggly little warnings.
Lee Jones (8):
backlight: lms501kf03: Remove unused const variables
backlight: lcd: Add missing kerneldoc entry for 'struct device parent'
quoted
backlight: ili922x: Add missing kerneldoc descriptions for
CHECK_FREQ_REG() args
backlight: ili922x: Remove invalid use of kerneldoc syntax
backlight: ili922x: Add missing kerneldoc description for
ili922x_reg_dump()'s arg
I wonder why these warnings show up as nothing pulls in this .c file.
Anyway I would suggest to drop using kerneldoc syntax for single drivers
like this - and the benefit here is low.
Now they are typed, otherwise this ahd been fine in a single patch.
What do you mean by 'nothing pulls it in'?
There are no .rst files that includes any:
.. kernel-doc:: drivers/video/backlight/ili922x.c
so I do not see how the kernel-doc comments will be used by any
of the generated kernel-docs.
Looks like a common problem (if it is actually a problem):
$ ./scripts/find-unused-docs.sh . | wc -l
1476
The role of this patch-set is not to eradicate unused kerneldoc
headers, but to ensure they are formatted correctly. W=1 builds
currently complain of ill formatted kerneldocs, which is currently
littering the build-log and masking some more important issues (which
I'm also trying to fix en route).
My point is that I do not see why we should maintain correct kernel-doc
style comments for files that are not used to to generate kernel-doc.
It would serve us better to drop the kernel-doc style comments.
But thats just my opinion, feel free to ignore.
I digged a little and can see we run kernel-doc on all .c files
when we specify W=1 - which was a suprise to me.
That explains why I had not seen said warnings in my regular make
htmldocs runs.
Sam
quoted
quoted
quoted
quoted
backlight: backlight: Supply description for function args in existing
Kerneldocs
backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0
backlight: qcom-wled: Remove unused configs for LED3 and LED4
The other fixes looks good.
They are all:
Acked-by: Sam Ravnborg <redacted>
From: Daniel Thompson <hidden> Date: 2020-06-26 09:54:12
On Thu, Jun 25, 2020 at 11:33:34AM +0100, Lee Jones wrote:
On Thu, 25 Jun 2020, Daniel Thompson wrote:
quoted
On Wed, Jun 24, 2020 at 03:57:16PM +0100, Lee Jones wrote:
quoted
Kerneldoc syntax is used, but not complete. Descriptions required.
Prevents warnings like:
drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 's' not described in 'CHECK_FREQ_REG'
drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 'x' not described in 'CHECK_FREQ_REG'
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Software Engineering <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/video/backlight/ili922x.c | 2 ++
1 file changed, 2 insertions(+)
What's wrong with "a pointer to an SPI device"?
I am aware, having looked it up to find out what the above actually
means, that this is how struct spi_device is described in its own kernel
doc but quoting at that level of detail of both overkill and confusing.
I figured that using the official description would be better than
making something up. However if you think it's better to KISS, then I
can change it.
Yes, I'd strongly prefer KISS here.
I know it is an "I am the world" argument[1] but I found using such a
dogmatically accurate description out of context to be very confusing
and therefore I don't think such a comment improves readability.
Daniel.
[1]: See #3 from http://www.leany.com/logic/Adams.html
From: Lee Jones <hidden> Date: 2020-06-26 15:33:56
On Fri, 26 Jun 2020, Daniel Thompson wrote:
On Thu, Jun 25, 2020 at 11:33:34AM +0100, Lee Jones wrote:
quoted
On Thu, 25 Jun 2020, Daniel Thompson wrote:
quoted
On Wed, Jun 24, 2020 at 03:57:16PM +0100, Lee Jones wrote:
quoted
Kerneldoc syntax is used, but not complete. Descriptions required.
Prevents warnings like:
drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 's' not described in 'CHECK_FREQ_REG'
drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 'x' not described in 'CHECK_FREQ_REG'
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Software Engineering <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/video/backlight/ili922x.c | 2 ++
1 file changed, 2 insertions(+)
What's wrong with "a pointer to an SPI device"?
I am aware, having looked it up to find out what the above actually
means, that this is how struct spi_device is described in its own kernel
doc but quoting at that level of detail of both overkill and confusing.
I figured that using the official description would be better than
making something up. However if you think it's better to KISS, then I
can change it.
Yes, I'd strongly prefer KISS here.
I know it is an "I am the world" argument[1] but I found using such a
dogmatically accurate description out of context to be very confusing
and therefore I don't think such a comment improves readability.
[1]: See #3 from http://www.leany.com/logic/Adams.html
It's fine, you are the world, I get it. ;)
Do you even like Country music?
Will fix!
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
From: Lee Jones <hidden> Date: 2020-07-06 07:12:59
On Thu, 25 Jun 2020, Daniel Thompson wrote:
On Wed, Jun 24, 2020 at 03:57:16PM +0100, Lee Jones wrote:
quoted
Kerneldoc syntax is used, but not complete. Descriptions required.
Prevents warnings like:
drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 's' not described in 'CHECK_FREQ_REG'
drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 'x' not described in 'CHECK_FREQ_REG'
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Software Engineering <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/video/backlight/ili922x.c | 2 ++
1 file changed, 2 insertions(+)
I've fixed this and applied the patch.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
From: Lee Jones <hidden> Date: 2020-07-06 07:13:29
On Thu, 25 Jun 2020, Daniel Thompson wrote:
On Wed, Jun 24, 2020 at 03:57:18PM +0100, Lee Jones wrote:
quoted
Kerneldoc syntax is used, but not complete. Descriptions required.
Prevents warnings like:
drivers/video/backlight/ili922x.c:298: warning: Function parameter or member 'spi' not described in 'ili922x_reg_dump'
Cc: <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Software Engineering <redacted>
Signed-off-by: Lee Jones <redacted>
---
drivers/video/backlight/ili922x.c | 2 ++
1 file changed, 2 insertions(+)
Similar to previous... and I also noticed that there are several other
existing @spi descriptions in this file and it would be good to make
them consistent.
I've fixed this and applied the patch.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
From: Lee Jones <hidden> Date: 2020-07-06 07:13:46
On Wed, 24 Jun 2020, Lee Jones wrote:
Attempting to clean-up W=1 kernel builds, which are currently
overwhelmingly riddled with niggly little warnings.
Lee Jones (8):
backlight: lms501kf03: Remove unused const variables
backlight: lcd: Add missing kerneldoc entry for 'struct device parent'
backlight: ili922x: Add missing kerneldoc descriptions for
CHECK_FREQ_REG() args
backlight: ili922x: Remove invalid use of kerneldoc syntax
backlight: ili922x: Add missing kerneldoc description for
ili922x_reg_dump()'s arg
backlight: backlight: Supply description for function args in existing
Kerneldocs
backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0
backlight: qcom-wled: Remove unused configs for LED3 and LED4
drivers/video/backlight/backlight.c | 2 ++
drivers/video/backlight/ili922x.c | 8 ++++++--
drivers/video/backlight/lcd.c | 1 +
drivers/video/backlight/lm3630a_bl.c | 4 ++--
drivers/video/backlight/lms501kf03.c | 8 --------
drivers/video/backlight/qcom-wled.c | 8 --------
6 files changed, 11 insertions(+), 20 deletions(-)
All applied to Backlight.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog