On 2020-01-22 16:25, Daniel Thompson wrote:

On Wed, Jan 22, 2020 at 09:32:40AM +0800, Chen Zhou wrote:

quoted

Fixes coccicheck warning:
./drivers/video/backlight/qcom-wled.c:1104:5-15:
	WARNING: Unsigned expression compared with zero: string_len > 0

The unsigned variable string_len is assigned a return value from the 
call
to of_property_count_elems_of_size(), which may return negative error 
code.

Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for 
WLED3")
Signed-off-by: Chen Zhou <redacted>
Reviewed-by: Bjorn Andersson <redacted>

Reviewed-by: Daniel Thompson <redacted>

Reviewed-by: Kiran Gunda <redacted>

quoted

---

changes in v2:
- fix commit message description.

---
 drivers/video/backlight/qcom-wled.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/backlight/qcom-wled.c 

b/drivers/video/backlight/qcom-wled.c
index d46052d..3d276b3 100644

--- a/drivers/video/backlight/qcom-wled.c
+++ b/drivers/video/backlight/qcom-wled.c

@@ -956,8 +956,8 @@ static int wled_configure(struct wled *wled, int 

version)
 	struct wled_config *cfg = &wled->cfg;
 	struct device *dev = wled->dev;
 	const __be32 *prop_addr;
-	u32 size, val, c, string_len;
-	int rc, i, j;
+	u32 size, val, c;
+	int rc, i, j, string_len;

 	const struct wled_u32_opts *u32_opts = NULL;
 	const struct wled_u32_opts wled3_opts[] = {
--
2.7.4