Re: [PATCH 07/10] video: fbdev: use resource_size
From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2020-01-15 16:10:17
Also in:
dri-devel, kernel-janitors, lkml
On 1/1/20 6:49 PM, Julia Lawall wrote:
quoted hunk ↗ jump to hunk
Use resource_size rather than a verbose computation on the end and start fields. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) <smpl>@@ struct resource ptr; @@ - (ptr.end - ptr.start + 1) + resource_size(&ptr)</smpl> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Patch queued for v5.6 (with patch summary modified slightly to reflect that this a change for cg14fb fbdev driver), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
quoted hunk ↗ jump to hunk
--- drivers/video/fbdev/cg14.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/video/fbdev/cg14.c b/drivers/video/fbdev/cg14.c index a620b51cf7d0..6a745eb46ca1 100644 --- a/drivers/video/fbdev/cg14.c +++ b/drivers/video/fbdev/cg14.c@@ -509,8 +509,7 @@ static int cg14_probe(struct platform_device *op) if (!par->regs || !par->clut || !par->cursor || !info->screen_base) goto out_unmap_regs; - is_8mb = (((op->resource[1].end - op->resource[1].start) + 1) = - (8 * 1024 * 1024)); + is_8mb = (resource_size(&op->resource[1]) = (8 * 1024 * 1024)); BUILD_BUG_ON(sizeof(par->mmap_map) != sizeof(__cg14_mmap_map));